Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update onboarding docs in context of issue #1046 #130

Merged
merged 10 commits into from
Nov 20, 2019
Merged

Update onboarding docs in context of issue #1046 #130

merged 10 commits into from
Nov 20, 2019

Conversation

yosheeck
Copy link
Contributor

@yosheeck yosheeck mentioned this pull request Nov 19, 2019
Closed
12 tasks
mdebarros
mdebarros requested changes Nov 19, 2019
View reviewed changes
Copy link
Member

@mdebarros mdebarros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comments. Let me know what you think of my suggested changes.

deployment-guide/deployment-troubleshooting.md Outdated Show resolved Hide resolved
deployment-guide/deployment-troubleshooting.md Show resolved Hide resolved
deployment-guide/deployment-troubleshooting.md Outdated Show resolved Hide resolved
deployment-guide/deployment-troubleshooting.md Outdated Show resolved Hide resolved
deployment-guide/README.md Outdated Show resolved Hide resolved
mdebarros
mdebarros requested changes Nov 19, 2019
View reviewed changes
Copy link
Member

@mdebarros mdebarros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for that, some minor suggested changes.

deployment-guide/README.md Outdated Show resolved Hide resolved
deployment-guide/deployment-troubleshooting.md Outdated Show resolved Hide resolved
deployment-guide/deployment-troubleshooting.md Outdated Show resolved Hide resolved
@yosheeck yosheeck requested a review from mdebarros November 20, 2019 08:10
mdebarros
mdebarros approved these changes Nov 20, 2019
View reviewed changes
Copy link
Member

@mdebarros mdebarros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@mdebarros mdebarros merged commit c599d5a into master Nov 20, 2019
@elnyry-sam-k elnyry-sam-k deleted the issue1046_updateOnboardingDocs branch November 20, 2019 10:51
aaronreynoza added a commit that referenced this pull request Feb 1, 2021
@aaronreynoza
Merge pull request #130 from mojaloop/added-benfords-law
18cb98d 
Added Benfords Law processing engine to typology 28.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdebarros mdebarros mdebarros approved these changes

@elnyry-sam-k elnyry-sam-k Awaiting requested review from elnyry-sam-k elnyry-sam-k is a code owner

@kjw000 kjw000 Awaiting requested review from kjw000

@millerabel millerabel Awaiting requested review from millerabel millerabel is a code owner

@NicoDuvenage NicoDuvenage Awaiting requested review from NicoDuvenage

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yosheeck @mdebarros