Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/535 Settlement Transfer Abort Impl #55

Merged
merged 7 commits into from
Dec 20, 2018
Merged
Show file tree
Hide file tree
Changes from 6 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions src/domain/settlement/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,9 @@ module.exports = {
return {
id: settlement.settlementId,
state: settlement.state,
reason: settlement.reason,
createdDate: settlement.createdDate,
changedDate: settlement.changedDate,
settlementWindows: settlementWindowsList,
participants
}
Expand All @@ -94,6 +97,7 @@ module.exports = {
},

putById: SettlementModel.putById,
abortById: SettlementModel.abortById,

getSettlementsByParams: async function (params, enums, options = {}) {
// 7 filters - at least one should be used
Expand Down Expand Up @@ -188,15 +192,15 @@ module.exports = {
// validate windows state
const settlementWindows = await SettlementWindowModel.getByListOfIds(idList, enums.settlementWindowStates)
if (settlementWindows.length && settlementWindows.length !== idList.length) {
let err = new Error('2001')
let err = new Error('Not all provided windows were found')
throw err
}

for (let settlementWindow of settlementWindows) {
let { state } = settlementWindow
if (state !== enums.settlementWindowStates.CLOSED &&
state !== enums.settlementWindowStates.ABORTED) {
let err = new Error('2001')
let err = new Error('At least one settlement window is not CLOSED/ABORTED')
throw err
}
}
Expand All @@ -208,6 +212,9 @@ module.exports = {
return {
id: settlement.settlementId,
state: settlement.state,
reason: settlement.reason,
createdDate: settlement.createdDate,
changedDate: settlement.changedDate,
settlementWindows: settlementWindowsList,
participants
}
Expand Down
16 changes: 14 additions & 2 deletions src/handlers/settlements/{id}.js
Original file line number Diff line number Diff line change
Expand Up @@ -72,9 +72,15 @@ module.exports = {
* responses: 200, 400, 401, 404, 415, default
*/

put: async function updateSettlementById (request, h) {
put: async function updateSettlementById (request) {
const settlementId = request.params.id
try {
const p = request.payload
if (p.participants && (p.state || p.reason || p.externalReference)) {
throw new Error('No other properties are allowed when participants is provided')
} else if ((p.state && !p.reason) || (!p.state && p.reason)) {
throw new Error('State and reason are mandatory')
}
const Enums = {
ledgerAccountTypes: await request.server.methods.enums('ledgerAccountTypes'),
ledgerEntryTypes: await request.server.methods.enums('ledgerEntryTypes'),
Expand All @@ -84,7 +90,13 @@ module.exports = {
transferParticipantRoleTypes: await request.server.methods.enums('transferParticipantRoleTypes'),
transferStates: await request.server.methods.enums('transferStates')
}
return await settlement.putById(settlementId, request.payload, Enums)
if (p.participants) {
return await settlement.putById(settlementId, request.payload, Enums)
} else if (p.state && p.state === Enums.settlementStates.ABORTED) {
return await settlement.abortById(settlementId, request.payload, Enums)
} else {
throw new Error('Invalid request payload input')
}
} catch (e) {
request.server.log('error', e)
return Boom.badRequest(e)
Expand Down
12 changes: 12 additions & 0 deletions src/interface/swagger.json
Original file line number Diff line number Diff line change
Expand Up @@ -875,6 +875,18 @@
"SettlementUpdatebySettlementIdPayload": {
"type": "object",
"properties": {
"state": {
"type": "string",
"enum": [
"ABORTED"
]
},
"reason": {
"type": "string"
},
"externalReference": {
"type": "string"
},
"participants": {
"type": "array",
"items": {
Expand Down
2 changes: 1 addition & 1 deletion src/lib/config.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,5 @@ module.exports = {
DATABASE_URI: RC.DATABASE_URI,
TRANSFER_VALIDITY_SECONDS: RC.TRANSFER_VALIDITY_SECONDS,
HUB_ID: RC.HUB_PARTICIPANT.ID,
HUB_NAME: RC.HUB_PARTICIPANT.NAME,
HUB_NAME: RC.HUB_PARTICIPANT.NAME
}
Loading