Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/1208 enhance get settlement by id to include window content #241

Closed
wants to merge 8 commits into from
Closed

Feature/1208 enhance get settlement by id to include window content #241

wants to merge 8 commits into from

Conversation

bothadeon
Copy link
Member

@bothadeon bothadeon commented Feb 12, 2020 •
edited
Loading

Enhance central-settlement : Return settlement window content for every settlement window when getting settlements by id.

  1. Updated dependancies in package.json.
  2. Updated the version to 9.1.0-snapshot.
  3. Add code to get src/domain/settlement/index.js : getById to add the window content to the current response object.
  4. Update unit testing and code coverage for added code.

@bothadeon bothadeon self-assigned this Feb 12, 2020
@ggrg ggrg mentioned this pull request Feb 12, 2020
Closed
13 tasks
ggrg
ggrg suggested changes Feb 12, 2020
View reviewed changes
src/domain/settlement/index.js Outdated Show resolved Hide resolved
@ggrg
Copy link
Member

ggrg commented Feb 12, 2020

Also, please add PR description, connect to story and bring your branch up-to-date with settlement-v2.

@rmothilal rmothilal requested a review from ggrg February 13, 2020 09:20
@bothadeon
Copy link
Member Author

Add description.

ggrg
ggrg suggested changes Feb 13, 2020
View reviewed changes
Copy link
Member

@ggrg ggrg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bothadeon, settlementId 1 is returning content associated with settlementId 2. Please, have a look and correct it

@ggrg
Copy link
Member

ggrg commented Feb 17, 2020 •
edited
Loading

@bothadeon, I'm afraid I can not review before we upgrade all services (central-ledger, simulator, central-settlement) to Node v12. Please, put the story to blocked and dependent on story #1175. When @oderayi is ready, I'll merge the changes from master to settlement-v2 branches, then you'll need to update this branch and make sure it's running properly and only then I'll be able to verify the PR. Thanks.

Code review change : added the filter on window content currency reco…
0169a13 
…rds being returned. Added code to delete unnecessary element in response object
@bothadeon bothadeon mentioned this pull request Feb 24, 2020
Closed
@bothadeon
Copy link
Member Author

Create a new pull request after local branch got corrupted. refer to : #255

@bothadeon bothadeon mentioned this pull request Mar 3, 2020
Merged
@rmothilal
Copy link
Contributor

@bothadeon is this still valid?

@rmothilal
Copy link
Contributor

closing replaced by pull request #255

@rmothilal rmothilal closed this Apr 23, 2020
@snyk-bot snyk-bot mentioned this pull request Aug 25, 2020
Open
@snyk-bot snyk-bot mentioned this pull request Jan 12, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Feb 9, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggrg ggrg ggrg requested changes

@vgenev vgenev Awaiting requested review from vgenev

@lazolalucas lazolalucas Awaiting requested review from lazolalucas

@rmothilal rmothilal Awaiting requested review from rmothilal

Assignees

@bothadeon bothadeon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bothadeon @ggrg @rmothilal