Settlement v2 deon #237
Settlement v2 deon #237
Conversation
…dler true without any modules.
…dated the version on central services shared to "8.8.2",
Changes: Added unit test for SettlementWindow handler
…tral-settlement into settlement-v2-deon
…ettlement into settlement-v2-deon # Conflicts: # package-lock.json # package.json
…ement into settlement-v2-deon
…ettlement into settlement-v2-deon
…ettlement into settlement-v2-deon
There was a problem hiding this comment.
Hi @bothadeon, this PR doesn't look right. It has too many commits which are not applicable to the story. It doesn't show conflicts with the base settlement-v2 branch, but probably due to improper merge from settlement-v2 your coverage and integration tests fail on circleci.
Please, discard this PR without merging and then checkout settlement-v2 from mojaloop, pull latest changes and start off with new feature branch, e.g. feature/1180EnhanceGetSettlementWindowById. Later on apply the changes and raise a new PR, which does not include commits, other than the ones applicable to the story. Coverage and integration tests should be passing on circleci, before the PR could be reviewed.
|
This pull request are being cancelled and replaced by : #238 |
'# tests 609
'# pass 609
'========================= Coverage summary ===============================
'Statements : 100% ( 1321/1321 )
'Branches : 99.47% ( 375/377 )
'Functions : 100% ( 185/185 )
'Lines : 100% ( 1282/1282 )
'=======================================================================