feat(mojaloop/#3984): parameterize switch id[BREAKING CHANGES] #385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oderayi
changed the title
|
oderayi
requested review from
mdebarros,
elnyry-sam-k,
vijayg10 and
kleyow
as code owners
vijayg10
approved these changes
Jun 25, 2024
oderayi
changed the title
61 tasks
geka-evk
reviewed
Jul 3, 2024
| if (!hubName) { | ||
| throw Error('"hubName" is not initialized. Initialize the cache first.') | ||
| } | ||
| if (!hubNameRegex) { |
There was a problem hiding this comment.
Can't we just calculate hubNameRegex here based on hubName (to avoid making it required)?, e.g.:
const { HeaderValidation } = require('@mojaloop/central-services-shared').Util
...
const hubNameRegex = HeaderValidation.getHubNameRegex(Config.HUB_NAME)
There was a problem hiding this comment.
You're right. Would reduce the number of parameters there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.