Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(mojaloop/#2814): added bulk quotes to header validation #334

Merged
merged 1 commit into from
Aug 15, 2022
Merged

fix(mojaloop/#2814): added bulk quotes to header validation #334

merged 1 commit into from
Aug 15, 2022

Conversation

vijayg10
Copy link
Contributor

@vijayg10 vijayg10 commented Aug 15, 2022 •
edited
Loading

fix(mojaloop/#2814): added bulk quotes to header validation mojaloop/#2814

@vijayg10 vijayg10 self-assigned this Aug 15, 2022
@vijayg10 vijayg10 changed the title fix: added bulk quotes to header validation fix(mojaloop/#2814): added bulk quotes to header validation Aug 15, 2022
mdebarros
mdebarros reviewed Aug 15, 2022
View reviewed changes
Copy link
Member

@mdebarros mdebarros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you not need to add this to the Types file as well?

I.e. https://github.com/vijayg10/central-services-shared/blob/fix/add-bulk-quotes-header-validation/src/index.d.ts

@vijayg10
Copy link
Contributor Author

Do you not need to add this to the Types file as well?

I.e. https://github.com/vijayg10/central-services-shared/blob/fix/add-bulk-quotes-header-validation/src/index.d.ts

No I searched for bulkTransfers to make sure if we miss any location. But its not referred there.

@vijayg10 vijayg10 mentioned this pull request Aug 15, 2022
Closed
35 tasks
mdebarros
mdebarros approved these changes Aug 15, 2022
View reviewed changes
Copy link
Member

@mdebarros mdebarros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@vijayg10 vijayg10 merged commit ab6c3f6 into mojaloop:master Aug 15, 2022
@vijayg10 vijayg10 deleted the fix/add-bulk-quotes-header-validation branch August 15, 2022 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdebarros mdebarros mdebarros approved these changes

@elnyry-sam-k elnyry-sam-k Awaiting requested review from elnyry-sam-k

@kleyow kleyow Awaiting requested review from kleyow

Assignees

@vijayg10 vijayg10

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vijayg10 @mdebarros