Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mojaloop/#2092): upgrade nodeJS version for core services #330

Conversation

mdebarros
Copy link
Member

@mdebarros mdebarros commented May 18, 2022

feat(mojaloop/#2092): upgrade nodeJS version for core services - mojaloop/project#2092

  • standardised CI scripts
  • fixed lint issues
  • updated .nvmrc to latest LTS version
  • added standard CI scripts/config to package.json: release, snapshot, standard-version, etc
  • updated gitignore to include test/results patterns
  • updated README with standard auto-release information
  • resolved audits
  • cleaned up package.json
  • updated links in changelog to point correctly to mojaloop issue repo
  • renamed .ncurc.json to .ncurc.js to add comment-note about the @hapi/catbox* issue as described in the notes below

Notes:

  • npm-audit-resolver v3.0.0-7 is a candidate release to resolve compatibility with npm v7+ as described in Doesn't work with npm@7 and above [work almost finished, see @next tag on npm] naugtur/npm-audit-resolver#34. This will need to be addressed going forward as npm run audit:resolve (i.e. resolve-audit) is currently not functioning. As a work-around, we need to manually run the following command npm audit fix. The npm run audit:check (i.e. check-audit) still works as expected.
  • Added "@hapi/catbox", "@hapi/catbox-memory" to ncurc for dep:check to ignore updates due to breaking changes which should be handled by another story

BREAKING CHANGE: major version bump for node v16 LTS support, and re-structuring of project directories to align to core Mojaloop repositories!

mdebarros added 8 commits May 18, 2022 16:33
feat(mojaloop/#2092): upgrade nodeJS version for core services - mojaloop/project#2092
- standardised CI scripts
- fixed lint issues
- updated .nvmrc to latest LTS version
- added standard CI scripts/config to package.json: release, snapshot, standard-version, etc
- updated gitignore to include test/results patterns
- updated README with standard auto-release information

Notes:
- npm-audit-resolver v3.0.0-7 is a candidate release to resolve compatibility with npm v7+ as described in naugtur/npm-audit-resolver#34. This will need to be addressed going forward as `npm run audit:resolve` (i.e. `resolve-audit`) is currently not functioning. As a work-around, we need to manually run the following command `npm audit fix`. The `npm run audit:check` (i.e. `check-audit`) still works as expected.
- Added "@hapi/catbox", "@hapi/catbox-memory" to ncurc for dep:check to ignore updates due to breaking changes which should be handled by another story

BREAKING CHANGE: major version bump for node v16 LTS support, and re-structuring of project directories to align to core Mojaloop repositories!
- removed unused files
- fixed lint issues
- updated nvmrc to 16.15.0
- resolved audits
- updated dependencies
- cleaned up package.json
- updated dependencies
- updated links in changelog to point correctly to mojaloop issue repo
elnyry-sam-k
elnyry-sam-k previously approved these changes May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants