do not modify the headers in jwsSigner (#220)

Co-authored-by: Shashi <shashikant.hirugade@modusbox.com>

package.json

@@ -1,6 +1,6 @@
 {
   "name": "@mojaloop/central-services-shared",
-  "version": "10.1.1",
+  "version": "10.1.2",
   "description": "Shared code for central services",
   "main": "src/index.js",
   "scripts": {
@@ -43,7 +43,7 @@
   "dependencies": {
     "@hapi/catbox": "11.1.0",
     "@hapi/catbox-memory": "5.0.0",
-    "@mojaloop/central-services-error-handling": "10.1.0",
+    "@mojaloop/central-services-error-handling": "10.2.0",
     "@mojaloop/central-services-logger": "9.5.1",
     "@mojaloop/central-services-metrics": "9.5.0",
     "@mojaloop/event-sdk": "9.5.2",
@@ -60,7 +60,7 @@
     "@hapi/hapi": "19.1.1",
     "@hapi/joi": "17.1.1",
     "@mojaloop/sdk-standard-components": "10.1.0",
-    "chance": "1.1.4",
+    "chance": "1.1.5",
     "faucet": "0.0.1",
     "npm-audit-resolver": "2.2.0",
     "npm-check-updates": "5.0.0",
@@ -70,7 +70,7 @@
     "rc": "1.2.8",
     "rewire": "5.0.0",
     "sinon": "9.0.2",
-    "standard": "14.3.3",
+    "standard": "14.3.4",
     "tap-xunit": "2.4.1",
     "tape": "5.0.0",
     "tapes": "4.1.0",

src/util/request.js

@@ -86,7 +86,7 @@ const sendRequest = async (url, headers, source, destination, method = enums.Htt
     }
     // if jwsSigner is passed then sign the request
     if (jwsSigner != null && typeof (jwsSigner) === 'object') {
-      jwsSigner.sign(requestOptions)
+      requestOptions.headers['fspiop-signature'] = jwsSigner.getSignature(requestOptions)
     }
 
     if (span) {

test/unit/util/request.test.js

@@ -197,7 +197,7 @@ Test('ParticipantEndpoint Model Test', modelTest => {
       })
       request = sandbox.stub().returns({ status: 200 })
       Model = proxyquire('../../../src/util/request', { axios: request })
-      const signSpy = Sinon.spy(jwsSigner, 'sign')
+      const signSpy = Sinon.spy(jwsSigner, 'getSignature')
       await Model.sendRequest(requestOptions.url, requestOptions.headers, Enum.Http.HeaderResources.SWITCH, fsp, requestOptions.method, payload, Enum.Http.ResponseTypes.JSON, undefined, jwsSigner)
       test.ok(signSpy.calledOnce, 'JwsSigner.sign is called once')
       test.ok('fspiop-signature' in signSpy.getCall(0).firstArg.headers, 'The header has fspiop-signature')
@@ -221,7 +221,7 @@ Test('ParticipantEndpoint Model Test', modelTest => {
       })
       request = sandbox.stub().returns({ status: 200 })
       Model = proxyquire('../../../src/util/request', { axios: request })
-      const signSpy = Sinon.spy(jwsSigner, 'sign')
+      const signSpy = Sinon.spy(jwsSigner, 'getSignature')
       await Model.sendRequest(requestOptions.url, requestOptions.headers, Enum.Http.HeaderResources.SWITCH, fsp, requestOptions.method, payload, Enum.Http.ResponseTypes.JSON, undefined, undefined)
       test.equal(signSpy.callCount, 0, 'JwsSigner.sign is NOT called')
       test.end()