Fix possible 'span already finished' bug in plugin (#177)

mojaloop · Feb 7, 2020 · 2aff75c · 2aff75c
1 parent 6c84b9a
commit 2aff75c
Show file tree

Hide file tree

Showing 3 changed files with 39 additions and 20 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@mojaloop/central-services-shared",
-  "version": "9.1.0",
+  "version": "9.1.1",
   "description": "Shared code for central services",
   "main": "src/index.js",
   "scripts": {

diff --git a/src/util/hapi/plugins/eventPlugin.js b/src/util/hapi/plugins/eventPlugin.js
@@ -45,6 +45,9 @@ const onPreAuth = (request, reply) => {
 
 const onPreResponse = async (request, reply) => {
   const span = request.span
+  if (span && span.isFinished) {
+    return reply.continue
+  }
   const response = request.response
   if (span) {
     if (response instanceof Error || response.isBoom) {