Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mojaloop/#3024): post /bulkTransfers from Switch to PayeeFSP to use Switch as fspiop-source #926

Conversation

mdebarros
Copy link
Member

@mdebarros mdebarros commented Nov 18, 2022

fix(mojaloop/#3024): [core bulk] POST /bulkTransfers from Switch to PayeeFSP to use Switch as fspiop-source - mojaloop/project#3024

  • updated fulfil-handler to only check routing headers on non-bulk actions
  • updated bulk-fulfil-handler validation to also accept "switch" as a valid DESTINATION header
  • updated dependencies

Related PRs:

…ayeeFSP to use Switch as fspiop-source

fix(mojaloop/#3024): [core bulk] POST /bulkTransfers from Switch to PayeeFSP to use Switch as fspiop-source - mojaloop/project#3024
- updated fulfil-handler to only check headers on non-bulk actions
- updated bulk-fulfil-handler validation to also accept "switch" as a valid DESTINATION header
@mdebarros mdebarros changed the title fix(mojaloop/#3024): [core bulk] POST /bulkTransfers from Switch to PayeeFSP to use Switch as fspiop-source fix(mojaloop/#3024): post /bulkTransfers from Switch to PayeeFSP to use Switch as fspiop-source Nov 18, 2022
@mdebarros mdebarros self-assigned this Nov 18, 2022
@mdebarros mdebarros marked this pull request as ready for review November 18, 2022 11:58
elnyry-sam-k
elnyry-sam-k previously approved these changes Nov 18, 2022
Copy link
Member

@elnyry-sam-k elnyry-sam-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Miguel, looks good; just a couple of minor suggestions on the comments..

mdebarros and others added 2 commits November 21, 2022 15:37
Co-authored-by: Sam <10507686+elnyry-sam-k@users.noreply.github.com>
Co-authored-by: Sam <10507686+elnyry-sam-k@users.noreply.github.com>
Copy link
Member

@elnyry-sam-k elnyry-sam-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor comment.. please review

Co-authored-by: Sam <10507686+elnyry-sam-k@users.noreply.github.com>
@mdebarros mdebarros merged commit bce2a23 into master Nov 21, 2022
@mdebarros mdebarros deleted the feat/#3024-post-bulkTransfers-from-Switch-to-PayeeFSP-to-use-Switch-as-fspiop-source branch November 21, 2022 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants