feat(2151): helm-release-v12.1.0

Onboarding.md

@@ -84,16 +84,9 @@ This will do the following:
 
 ### 3.2 Configure the DB environment variable and run the server
 
-> Note: Ensure that the `sidecar` has been disabled (`SIDECAR.DISABLED=true` is disabled in the `./config/default.json`) or set environment var `export CLEDG_SIDECAR__DISABLED=true`).
 > Note: If you do disable Mongodb (i.e. `CLEDG_MONGODB__DISABLED=true`), please ensure that you comment out the following line `sh /opt/wait-for/wait-for-objstore.sh` from the following file: `docker/wait-for/wait-for-central-ledger.sh`.
 
 ```bash
-# disable SIDECAR in config/default.json temporary by setting 
-# "SIDECAR": { "DISABLED": "true", ...
-
-# Disable the SIDECAR (required)
-export CLEDG_SIDECAR__DISABLED=true
-
 # Disable the MongoDB (optional)
 export CLEDG_MONGODB__DISABLED=true
 

config/default.json

@@ -26,13 +26,6 @@
     "PRECISION": 18,
     "SCALE": 4
   },
-  "SIDECAR": {
-    "DISABLED": true,
-    "HOST": "localhost",
-    "PORT": 5678,
-    "CONNECT_TIMEOUT": 45000,
-    "RECONNECT_INTERVAL": 5000
-  },
   "MONGODB": {
     "DISABLED": true,
     "URI": "mongodb://localhost:27017/mlos"

docker-compose.integration.yml

@@ -20,7 +20,6 @@ services:
       - ./src:/opt/central-ledger/src
       # - ./node_modules:/opt/central-ledger/node_modules
     environment:
-      - CLEDG_SIDECAR__DISABLED=true
       - CLEDG_MONGODB__DISABLED=true
     command:
       - tail

docker-compose.yml

@@ -24,7 +24,6 @@ services:
     environment:
       - LOG_LEVEL=info
       - CSL_LOG_TRANSPORT=file
-      - CLEDG_SIDECAR__DISABLED=true
       - CLEDG_MONGODB__DISABLED=false
     networks:
       - cl-mojaloop-net

docker/central-ledger/default.json

@@ -26,13 +26,6 @@
     "PRECISION": 10,
     "SCALE": 2
   },
-  "SIDECAR": {
-    "DISABLED": true,
-    "HOST": "localhost",
-    "PORT": 5678,
-    "CONNECT_TIMEOUT": 45000,
-    "RECONNECT_INTERVAL": 5000
-  },
   "MONGODB": {
     "DISABLED": false,
     "URI": "mongodb://objstore:27017/mlos"

package.json

@@ -126,7 +126,6 @@
     "mysql": "2.18.1"
   },
   "devDependencies": {
-    "@mojaloop/forensic-logging-client": "8.3.0",
     "async-retry": "1.3.1",
     "faucet": "0.0.1",
     "get-port": "5.1.1",

src/api/ledgerAccountTypes/handler.js

@@ -25,14 +25,12 @@
 'use strict'
 
 const LedgerAccountTypesService = require('../../domain/ledgerAccountTypes')
-const Sidecar = require('../../lib/sidecar')
 const ErrorHandler = require('@mojaloop/central-services-error-handling')
 
 const getAll = async function () {
   return LedgerAccountTypesService.getAll()
 }
 async function create (request, h) {
-  Sidecar.logRequest(request)
   try {
     const ledgerAccountTypeExist = await LedgerAccountTypesService.getByName(request.payload.name)
     if (ledgerAccountTypeExist) {

src/api/participants/handler.js

@@ -28,7 +28,6 @@ const ParticipantService = require('../../domain/participant')
 const UrlParser = require('../../lib/urlParser')
 const Config = require('../../lib/config')
 const Util = require('@mojaloop/central-services-shared').Util
-const Sidecar = require('../../lib/sidecar')
 const Logger = require('@mojaloop/central-services-logger')
 const ErrorHandler = require('@mojaloop/central-services-error-handling')
 const Enums = require('../../lib/enumCached')
@@ -71,7 +70,6 @@ const handleMissingRecord = (entity) => {
 }
 
 const create = async function (request, h) {
-  Sidecar.logRequest(request)
   Logger.isDebugEnabled && Logger.debug(`create: request - ${JSON.stringify(request)}`)
   try {
     const ledgerAccountTypes = await Enums.getEnums('ledgerAccountType')
@@ -115,7 +113,6 @@ const create = async function (request, h) {
 }
 
 const createHubAccount = async function (request, h) {
-  Sidecar.logRequest(request)
   Logger.isDebugEnabled && Logger.debug(`createHubAccount: request - ${JSON.stringify(request)}`)
   try {
     // start - To Do move to domain
@@ -179,7 +176,6 @@ const getByName = async function (request) {
 }
 
 const update = async function (request) {
-  Sidecar.logRequest(request)
   Logger.isDebugEnabled && Logger.debug(`update: request - ${JSON.stringify(request)}`)
   try {
     const updatedEntity = await ParticipantService.update(request.params.name, request.payload)
@@ -198,7 +194,6 @@ const update = async function (request) {
 }
 
 const addEndpoint = async function (request, h) {
-  Sidecar.logRequest(request)
   Logger.isDebugEnabled && Logger.debug(`addEndpoint: request - ${JSON.stringify(request)}`)
   try {
     await ParticipantService.addEndpoint(request.params.name, request.payload)
@@ -210,7 +205,6 @@ const addEndpoint = async function (request, h) {
 }
 
 const getEndpoint = async function (request) {
-  Sidecar.logRequest(request)
   Logger.isDebugEnabled && Logger.debug(`getEndpoint: request - ${JSON.stringify(request)}`)
   try {
     if (request.query.type) {
@@ -243,7 +237,6 @@ const getEndpoint = async function (request) {
 }
 
 const addLimitAndInitialPosition = async function (request, h) {
-  Sidecar.logRequest(request)
   Logger.isDebugEnabled && Logger.debug(`addLimitAndInitialPosition: request - ${JSON.stringify(request)}`)
   try {
     await ParticipantService.addLimitAndInitialPosition(request.params.name, request.payload)
@@ -255,7 +248,6 @@ const addLimitAndInitialPosition = async function (request, h) {
 }
 
 const getLimits = async function (request) {
-  Sidecar.logRequest(request)
   Logger.isDebugEnabled && Logger.debug(`getLimits: request - ${JSON.stringify(request)}`)
   try {
     const result = await ParticipantService.getLimits(request.params.name, request.query)
@@ -280,7 +272,6 @@ const getLimits = async function (request) {
 }
 
 const getLimitsForAllParticipants = async function (request) {
-  Sidecar.logRequest(request)
   Logger.isDebugEnabled && Logger.debug(`getLimitsForAllParticipants: request - ${JSON.stringify(request)}`)
   try {
     const result = await ParticipantService.getLimitsForAllParticipants(request.query)
@@ -306,7 +297,6 @@ const getLimitsForAllParticipants = async function (request) {
 }
 
 const adjustLimits = async function (request, h) {
-  Sidecar.logRequest(request)
   Logger.isDebugEnabled && Logger.debug(`adjustLimits: request - ${JSON.stringify(request)}`)
   try {
     const result = await ParticipantService.adjustLimits(request.params.name, request.payload)
@@ -328,7 +318,6 @@ const adjustLimits = async function (request, h) {
 }
 
 const getPositions = async function (request) {
-  Sidecar.logRequest(request)
   Logger.isDebugEnabled && Logger.debug(`getPositions: request - ${JSON.stringify(request)}`)
   try {
     return await ParticipantService.getPositions(request.params.name, request.query)
@@ -339,7 +328,6 @@ const getPositions = async function (request) {
 }
 
 const getAccounts = async function (request) {
-  Sidecar.logRequest(request)
   Logger.isDebugEnabled && Logger.debug(`getAccounts: request - ${JSON.stringify(request)}`)
   try {
     return await ParticipantService.getAccounts(request.params.name, request.query)
@@ -350,7 +338,6 @@ const getAccounts = async function (request) {
 }
 
 const updateAccount = async function (request, h) {
-  Sidecar.logRequest(request)
   Logger.isDebugEnabled && Logger.debug(`updateAccount: request - ${JSON.stringify(request)}`)
   try {
     const enums = {
@@ -370,7 +357,6 @@ const updateAccount = async function (request, h) {
 }
 
 const recordFunds = async function (request, h) {
-  Sidecar.logRequest(request)
   Logger.isDebugEnabled && Logger.debug(`recordFunds: request - ${JSON.stringify(request)}`)
   try {
     const enums = await Enums.getEnums('all')

src/api/settlementModels/handler.js

@@ -26,7 +26,6 @@
 'use strict'
 
 const SettlementService = require('../../domain/settlement')
-const Sidecar = require('../../lib/sidecar')
 const ErrorHandler = require('@mojaloop/central-services-error-handling')
 const Enums = require('../../lib/enumCached')
 const Util = require('@mojaloop/central-services-shared').Util
@@ -77,7 +76,6 @@ const getAll = async function () {
 }
 
 const update = async function (request) {
-  Sidecar.logRequest(request)
   try {
     const updatedEntity = await SettlementService.update(request.params.name, request.payload)
     if (request.payload.isActive !== undefined) {
@@ -96,7 +94,6 @@ const update = async function (request) {
   }
 }
 const create = async function (request, h) {
-  Sidecar.logRequest(request)
   try {
     await SettlementService.createSettlementModel(request.payload)
     return h.response().code(201)

src/lib/config.js

@@ -7,8 +7,6 @@ module.exports = {
   MONGODB_DISABLED: RC.MONGODB.DISABLED,
   AMOUNT: RC.AMOUNT,
   EXPIRES_TIMEOUT: RC.EXPIRES_TIMEOUT,
-  SIDECAR: RC.SIDECAR,
-  SIDECAR_DISABLED: RC.SIDECAR.DISABLED,
   ERROR_HANDLING: RC.ERROR_HANDLING,
   HANDLERS: RC.HANDLERS,
   HANDLERS_DISABLED: RC.HANDLERS.DISABLED,