Feature/693 Bulk Transfers Design #267
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ggrg
commented
Apr 4, 2019
•
ggrg
commented
- Bulk Transfers Migrations
- Bulk Transfer State lookup values
- Bulk Processing State lookup values
31 tasks
NicoDuvenage
previously approved these changes
Apr 5, 2019
There was a problem hiding this comment.
👍 It looks good - We just need to have a chat about the transferFulfilmentDuplicateCheck process and how it is implemented as I see you removed a section of code and a placemarker, but go ahead with this merge. Thanks (And I see the coverage check did not pass)
mdebarros
requested changes
Apr 5, 2019
|
@mdebarros, it is just I preferred writing knex migration scripts and commit to github, rather than working with MySQL Workbench and having migration scripts work due. |
|
Closing this PR as it is now outdated and migrations have been moved here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.