Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hotfix for Duplicate on POST /transfer response #262

Merged
merged 1 commit into from
Mar 21, 2019
Merged

Hotfix for Duplicate on POST /transfer response #262

merged 1 commit into from
Mar 21, 2019

Conversation

mdebarros
Copy link
Member

@mdebarros mdebarros commented Mar 20, 2019 •
edited
Loading

Fix for mojaloop/project#687:

  • Updated Duplicate on POST /transfer response to return the FSPIOP-Source='switch'

@mdebarros mdebarros self-assigned this Mar 20, 2019
@mdebarros mdebarros added the bug label Mar 20, 2019
vgenev
vgenev approved these changes Mar 20, 2019
View reviewed changes
Copy link
Contributor

@vgenev vgenev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

happy

ggrg
ggrg approved these changes Mar 20, 2019
View reviewed changes
Copy link
Member

@ggrg ggrg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy with the update, just a suggestion: keeping short PR titles (merge messages), while utilising PR description text would be better, as well as having category specified - hotfix/ bugfix/ feature/.

@mdebarros mdebarros changed the title Updated Duplicate on POST /transfer response to return the FSPIOP-Source='switch' Hotfix for Duplicate on POST /transfer response to return the FSPIOP-Source='switch' Mar 20, 2019
@mdebarros mdebarros changed the title Hotfix for Duplicate on POST /transfer response to return the FSPIOP-Source='switch' Hotfix for Duplicate on POST /transfer response Mar 20, 2019
@mdebarros mdebarros merged commit ab0a9d4 into mojaloop:master Mar 21, 2019
@mdebarros mdebarros mentioned this pull request Mar 21, 2019
Closed
7 tasks
@snyk-bot snyk-bot mentioned this pull request Jan 15, 2021
Open
@snyk-bot snyk-bot mentioned this pull request Apr 8, 2021
Open
@snyk-bot snyk-bot mentioned this pull request May 13, 2021
Open
@rasputtintin rasputtintin mentioned this pull request May 19, 2022
Open
@rasputtintin rasputtintin mentioned this pull request Aug 24, 2023
Open
@rasputtintin rasputtintin mentioned this pull request Nov 30, 2023
Open
@rasputtintin rasputtintin mentioned this pull request Dec 19, 2023
Open
@rasputtintin rasputtintin mentioned this pull request Jan 1, 2024
Open
@rasputtintin rasputtintin mentioned this pull request Mar 15, 2024
Open
@rasputtintin rasputtintin mentioned this pull request Mar 22, 2024
Open
@rasputtintin rasputtintin mentioned this pull request Apr 15, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggrg ggrg ggrg approved these changes

@vgenev vgenev vgenev approved these changes

@elnyry-sam-k elnyry-sam-k Awaiting requested review from elnyry-sam-k

@HenkKodde HenkKodde Awaiting requested review from HenkKodde

@NicoDuvenage NicoDuvenage Awaiting requested review from NicoDuvenage

@rmothilal rmothilal Awaiting requested review from rmothilal

Assignees

@mdebarros mdebarros

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mdebarros @vgenev @ggrg