Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

story #604 update node version and modules version #245

Merged
merged 4 commits into from
Feb 12, 2019
Merged

story #604 update node version and modules version #245

merged 4 commits into from
Feb 12, 2019

Conversation

shashi165
Copy link
Contributor

Changes for Story #604

Tests

=============================== Coverage summary ===============================
Statements   : 100% ( 2951/2951 )
Branches     : 100% ( 715/715 )
Functions    : 100% ( 412/412 )
Lines        : 100% ( 2925/2925 )
================================================================================

1..1101
# tests 1101
# pass  1101

# ok

@shashi165 shashi165 self-assigned this Feb 11, 2019
@mdebarros mdebarros mentioned this pull request Feb 11, 2019
Closed
37 tasks
rmothilal
rmothilal requested changes Feb 12, 2019
View reviewed changes
Copy link
Contributor

@rmothilal rmothilal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see comments

src/domain/position/index.js Show resolved Hide resolved
src/domain/timeout/index.js
@@ -39,19 +39,23 @@ const getTimeoutSegment = async () => {
enumeration: 0,
tableName: 'transferStateChange'
}
return await SegmentModel.getByParams(params)
let result = await SegmentModel.getByParams(params)
return result
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is the result assigned to a variable and then returned? Could it not be done in one line with return await?

src/domain/timeout/index.js Show resolved Hide resolved
src/domain/timeout/index.js Show resolved Hide resolved
src/domain/timeout/index.js Show resolved Hide resolved
src/handlers/lib/utility.js Show resolved Hide resolved
src/handlers/lib/utility.js Show resolved Hide resolved
src/lib/urlParser.js Show resolved Hide resolved
rmothilal
rmothilal approved these changes Feb 12, 2019
View reviewed changes
Copy link
Contributor

@rmothilal rmothilal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy

@shashi165 shashi165 merged commit 2a1fdd8 into mojaloop:master Feb 12, 2019
@snyk-bot snyk-bot mentioned this pull request Aug 25, 2020
Open
@snyk-bot snyk-bot mentioned this pull request Jan 12, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Feb 9, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmothilal rmothilal rmothilal approved these changes

@elnyry-sam-k elnyry-sam-k Awaiting requested review from elnyry-sam-k

@mdebarros mdebarros Awaiting requested review from mdebarros

Assignees

@shashi165 shashi165

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shashi165 @rmothilal