Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added new message to notification topic for limit adjustment. #236

Merged
merged 6 commits into from
Jan 24, 2019
Merged

added new message to notification topic for limit adjustment. #236

merged 6 commits into from
Jan 24, 2019

Conversation

vgenev
Copy link
Contributor

@vgenev vgenev commented Jan 24, 2019 •
edited
Loading

Added producing new message to the Kafka Notification Topic for limit adjustment through Admin API

ggrg
ggrg requested changes Jan 24, 2019
View reviewed changes
Copy link
Member

@ggrg ggrg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, please provide improved PR description if possible and self-assign to the PR.

src/domain/participant/index.js Outdated Show resolved Hide resolved
src/domain/participant/index.js Outdated Show resolved Hide resolved
@vgenev vgenev self-assigned this Jan 24, 2019
@vgenev vgenev changed the title added new message to notification topic for limit adjustment. tests s… added new message to notification topic for limit adjustment. Jan 24, 2019
ggrg
ggrg approved these changes Jan 24, 2019
View reviewed changes
Copy link
Member

@ggrg ggrg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Ready to be merged after circle ci checks pass.

bothadeon
bothadeon reviewed Jan 24, 2019
View reviewed changes
Copy link
Member

@bothadeon bothadeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good

@vgenev vgenev merged commit 6f24564 into mojaloop:master Jan 24, 2019
@elnyry-sam-k elnyry-sam-k mentioned this pull request Jan 24, 2019
Closed
33 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bothadeon bothadeon bothadeon left review comments

@ggrg ggrg ggrg approved these changes

@rmothilal rmothilal Awaiting requested review from rmothilal

Assignees

@vgenev vgenev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vgenev @bothadeon @ggrg