Update error message (#749)

* Update error message when Payer FSP and Payee FSP are the same and on-us is not enabled.. (Added text "FSP" to specify)

* Updated unit test

package.json

@@ -1,6 +1,6 @@
 {
   "name": "@mojaloop/central-ledger",
-  "version": "10.4.5",
+  "version": "10.5.0",
   "description": "Central ledger hosted by a scheme to record and settle transfers",
   "license": "Apache-2.0",
   "author": "ModusBox",
@@ -12,6 +12,7 @@
     "Lewis Daly <lewisd@crosslaketech.com>",
     "Miguel de Barros <miguel.debarros@modusbox.com>",
     "Rajiv Mothilal <rajiv.mothilal@modusbox.com>",
+    "Sam Kummary <sam@modusbox.com>",
     "Steven Oderayi <steven.oderayi@modusbox.com>",
     "Valentin Genev <valentin.genev@modusbox.com>"
   ],

src/handlers/transfers/validator.js

@@ -26,6 +26,8 @@
  * Georgi Logodazhki <georgi.logodazhki@modusbox.com>
  * Rajiv Mothilal <rajiv.mothilal@modusbox.com>
  * Miguel de Barros <miguel.debarros@modusbox.com>
+ * Sam Kummary <sam@modusbox.com>
+ * Vijaya Kumar Guthi <vijay.guthi@modusbox.com>
 
  --------------
  ******/
@@ -89,7 +91,7 @@ const validateDifferentDfsp = (payload) => {
   if (!Config.ENABLE_ON_US_TRANSFERS) {
     const isPayerAndPayeeDifferent = (payload.payerFsp.toLowerCase() !== payload.payeeFsp.toLowerCase())
     if (!isPayerAndPayeeDifferent) {
-      reasons.push('Payer and Payee should be different')
+      reasons.push('Payer FSP and Payee FSP should be different, unless on-us tranfers are allowed by the Scheme')
       return false
     }
   }

test/unit/handlers/transfers/validator.test.js

@@ -197,7 +197,7 @@ Test('transfer validator', validatorTest => {
 
       const { validationPassed, reasons } = await Validator.validatePrepare(payload, headers)
       test.equal(validationPassed, false)
-      test.deepEqual(reasons, ['Payer and Payee should be different'])
+      test.deepEqual(reasons, ['Payer FSP and Payee FSP should be different, unless on-us tranfers are allowed by the Scheme'])
       test.end()
     })