Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/1003 Add Anchore image scanning, upgrade to CircleCI 2.1 #89

Merged
merged 3 commits into from
Dec 3, 2019

Conversation

lewisdaly
Copy link
Contributor

@lewisdaly lewisdaly commented Nov 9, 2019

Part of #1003

  • initial steps to add anchore scanning to docker images
  • update CircleCI to 2.1
  • clean up CircleCI config by merging the snapshot logic in with main flow. This was required because the logic diverged at the build step. If we didn't clean this up, everything added after build would need to be duplicated

I tested this updated workflow with a snapshot release. Here is what the new workflow looks like:

Screen Shot 2019-11-30 at 9 37 32 am

@lewisdaly lewisdaly changed the title Initial changes to circleci config feature/1003 Add Anchore image scanning, upgrade to CircleCI 2.1 Nov 30, 2019
add branch to trigger ci build

Add default envs for testing

Add default envs for testing

Add default envs for testing

working on test envs

working on test envs

work on removing snapshot setup

work on removing snapshot setup

working on deploy snapshot config

working on deploy snapshot config

working on deploy snapshot config

working on deploy snapshot config

remove release tag until end

debugging issues with anchore reporting

debugging issues with anchore reporting

debugging issues with anchore reporting

debugging issues with anchore reporting

debugging issues with anchore reporting

debugging issues with anchore reporting

debugging issues with anchore reporting

debugging issues with anchore reporting

remove comments and unneeded code from circleci config
@lewisdaly lewisdaly force-pushed the feature/1003-container-scanning branch from 0235d3b to 99c2a5c Compare November 30, 2019 01:29
Copy link

@rmothilal rmothilal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy

@lewisdaly lewisdaly merged commit c7e984a into master Dec 3, 2019
@lewisdaly lewisdaly deleted the feature/1003-container-scanning branch December 3, 2019 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants