fix(mojaloop/#2538): fspiop api version negotiation not handled #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fix(mojaloop/#2538): fspiop api version negotiation not handled - mojaloop/project#2538 - added getOptionsForFSPIOPHeaderValidation to the plugin configuration - added new config key for PROTOCOL_VERSIONS to default and integration configs - added DEFAULT_PROTOCOL_VERSION for backward compatibility - updated config and unit tests to FSPIOP v1.1 protocol version - BKAPI_PROTOCOL_VERSIONS__ACCEPT__VALIDATELIST can be set as follows "[ \"1\", \"1.1\"]" and it will be parsed correctly into a object - Added unit tests for config changes BREAKING CHANGE: Forcing a major version change for awareness of the config changes. The `LIB_RESOURCE_VERSIONS` env var is now deprecated, and this is now also controlled by the PROTOCOL_VERSIONS config in the default.json. This has been done for consistency between all API services going forward and unifies the config for both inbound and outbound Protocol API validation/transformation features.
- updated central-object-store to object-store-lib, and aligned imports in code - updated all dependencies - fixed audit issues
- updated circleci config - added standard-version dependency and release script to package.json
mdebarros
requested review from
elnyry-sam-k,
lewisdaly,
oderayi,
shashi165 and
vgenev
as code owners
elnyry-sam-k
approved these changes
Nov 17, 2021
This was referenced Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(mojaloop/#2538): fspiop api version negotiation not handled - FSPIOP API version negotiation not handled - Bulk-api-adapter project#2538
chore: added automated ci-cd release configs for circleci
chore: changed circleci config to use the commit sha1 instead of package checksum to fix caching issues
BREAKING CHANGE: Forcing a major version change for awareness of the config changes. The
LIB_RESOURCE_VERSIONSenv var is now deprecated, and this is now also controlled by the PROTOCOL_VERSIONS config in the default.json. This has been done for consistency between all API services going forward and unifies the config for both inbound and outbound Protocol API validation/transformation features.