refactor!: update auth-service to latest thirdparty api definition #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lewisdaly
reviewed
Mar 23, 2022
migrations/20220322001917_address.ts
Outdated
| .then((exists: boolean): Knex.SchemaBuilder | void => { | ||
| if (exists) { | ||
| return knex.schema.alterTable('Scope', function (table) { | ||
| table.renameColumn('address', 'address') |
There was a problem hiding this comment.
What is this migration doing?
There was a problem hiding this comment.
This is ment to rename accountId to address. I must be sleep deprived.
| } | ||
|
|
||
| export function down (knex: Knex): Promise<void | Knex.SchemaBuilder> { | ||
| return knex.schema.hasTable('Scope') |
There was a problem hiding this comment.
This is meant to reverse whatever the migration was, but I'm not sure what that is, so I can't tell if this is correct
| @@ -49,13 +49,13 @@ const PostThirdpartyRequestsVerificationsRequest = { | |||
| }, | |||
| params: {}, | |||
| payload: { | |||
| //TODO: | |||
| // TODO: | |||
There was a problem hiding this comment.
TODO what? Either we need a follow-up story to do whats needed here or remove this
src/domain/challenge.ts
Outdated
| const RFC8785String = canonicalize(rawChallenge) | ||
| console.log(RFC8785String) |
elnyry-sam-k
approved these changes
Mar 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.