Skip to content

Commit

Permalink
fix: remove devDependencies from docker image (#92)
Browse files Browse the repository at this point in the history
* fix: remove devDependencies from docker image

* fix: move devDependencies to dependencies

* fix: `SLACK_WEBHOOK_ANNOUNCEMENT_CI_CD` env var
  • Loading branch information
lewisdaly authored Sep 28, 2021
1 parent 14c80c6 commit 888ca8e
Show file tree
Hide file tree
Showing 4 changed files with 20 additions and 43 deletions.
2 changes: 1 addition & 1 deletion .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -390,7 +390,7 @@ jobs:
docker push $DOCKER_ORG/$CIRCLE_PROJECT_REPONAME:${CIRCLE_TAG}
- slack/status:
fail_only: true
webhook: "$SLACK_WEBHOOK_ANNOUNCMENT_CI_CD"
webhook: "$SLACK_WEBHOOK_ANNOUNCEMENT_CI_CD"
failure_message: 'Publishing docker image failed for: \`"${DOCKER_ORG}/${CIRCLE_PROJECT_REPONAME}:${CIRCLE_TAG}"\`'

license-scan:
Expand Down
3 changes: 1 addition & 2 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ USER as-user
COPY --chown=as-user --from=builder /opt/auth-service .

# cleanup
# disable prune, breaks tests
# RUN npm prune --production
RUN npm prune --production
EXPOSE 4004
CMD ["npm", "run", "start"]
38 changes: 8 additions & 30 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

20 changes: 10 additions & 10 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -75,16 +75,9 @@
"@commitlint/cli": "^12.1.4",
"@commitlint/config-conventional": "^12.1.4",
"@redocly/openapi-cli": "^1.0.0-beta.53",
"@types/hapi": "^18.0.5",
"@types/hapi__hapi": "^20.0.8",
"@types/hapi__inert": "^5.2.2",
"@types/hapi__vision": "^5.5.2",
"@types/rc": "^1.1.0",
"@types/redis-mock": "^0.17.0",
"@typescript-eslint/eslint-plugin": "^4.28.2",
"@typescript-eslint/parser": "^4.28.2",
"add": "^2.0.6",
"axios": "^0.21.1",
"eslint": "7.30.0",
"eslint-config-prettier": "8.3.0",
"eslint-config-standard": "16.0.3",
Expand All @@ -110,11 +103,10 @@
"sqlite3": "^5.0.2",
"standard-version": "^9.3.0",
"swagger-cli": "^4.0.4",
"ts-jest": "^27.0.5",
"tsconfig-paths": "^3.10.1",
"typescript": "4.3.5"
"ts-jest": "^27.0.5"
},
"dependencies": {
"axios": "^0.21.1",
"@hapi/boom": "^9.1.3",
"@hapi/good": "^9.0.1",
"@hapi/hapi": "^20.1.5",
Expand All @@ -136,6 +128,12 @@
"@types/promise-timeout": "^1.3.0",
"@types/redis": "^2.8.28",
"@types/uuid": "^8.3.1",
"@types/hapi": "^18.0.5",
"@types/hapi__hapi": "^20.0.8",
"@types/hapi__inert": "^5.2.2",
"@types/hapi__vision": "^5.5.2",
"@types/rc": "^1.1.0",
"@types/redis-mock": "^0.17.0",
"ajv": "8.6.0",
"ajv-keywords": "5.0.0",
"atob": "^2.1.2",
Expand Down Expand Up @@ -164,6 +162,8 @@
"redis": "^3.1.2",
"string-to-arraybuffer": "^1.0.2",
"ts-node": "^10.0.0",
"tsconfig-paths": "^3.10.1",
"typescript": "4.3.5",
"uuid": "^8.3.2"
},
"peerDependencies": {
Expand Down

0 comments on commit 888ca8e

Please sign in to comment.