chore: add tp scheme adapter snippets. clarify auth wording #22
Conversation
kleyow
commented
Sep 10, 2020
kleyow
commented
- add more snippets from the tp-scheme-adapter
- move away from "Auth" as a naming to avoid confusion between Authorization and Authentication (please double check that the are named correctly 😅 )
There was a problem hiding this comment.
Thanks Kevin - this is important to clean up and make easier to understand.
Here's some suggestions for naming conventions that might make things simpler:
- we should try to avoid the term
Authorization(s)in the thirdparty-api where possible - and keepAuthorization(s)for the FSPIOP-API methods/objects etc. that we copied across - For auth stuff related to
ConsentsorConsentRequests, maybe we can use Consent or Consent Request (e.g.ConsentRequestChannelTypeinstead ofAuthorizationChannelType
|
Thank you for clarifying and expanding on this Lewis. Glad we are ironing this out. |
thirdparty/openapi3/schemas/ThirdpartyAuthorizationIDPostResponse.yaml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Scheme related interfaces are dedicated to synchronous operations (especially Outbound interfaces) which are merging gathering responses from asynchronous flows driven by state machines. They should be separated from core Switch interfaces. But the Scheme Inbound interfaces should match exactly the core Switch interfaces which should be implemented by DFSP/Thridparty
chore: address comments chore: fix example chore: remove property
kleyow
force-pushed
the
chore/more-snippets
branch
from
70ec5be
to
b9865f1
Compare
|
Scheme related stuff removed. |
There was a problem hiding this comment.
lgtm, but let wait on @lewisdaly before merge -> please take a look here also: mojaloop/pisp-project#66
| properties: | ||
| challenge: | ||
| type: string | ||
| description: The original Challenge Object as a JSON string |
There was a problem hiding this comment.
we shouldn't use JSON.stringify as stringify method because it can generate non-identical strings, there is a need for additional design decision see: mojaloop/pisp-project#66
|
The issue has been bubbled up to design. Going to merge this since it's blocking swagger documentation. |
|
hhhqqqqqw vbv gggggvhqqq1
…On Wed, 16 Sep 2020, 05:51 Kevin Leyow, ***@***.***> wrote:
Merged #22 <#22> into master.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#22 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AIU7NBKSMMOTE5AY4324GWLSGAY5NANCNFSM4RDZWO6Q>
.
|
