Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: adding currencies xxx and xts which are part of iso 4217 #115

Merged
merged 8 commits into from
Oct 19, 2021
Merged

fix: adding currencies xxx and xts which are part of iso 4217 #115

merged 8 commits into from
Oct 19, 2021

Conversation

sivachundur
Copy link
Contributor

No description provided.

kleyow
kleyow previously approved these changes Oct 19, 2021
View reviewed changes
elnyry-sam-k
elnyry-sam-k previously approved these changes Oct 19, 2021
View reviewed changes
@kleyow
Copy link
Contributor

kleyow commented Oct 19, 2021

Oh @sivachundur don't merge this. Debump package.json and package-lock.json.
This repo has automated bumping and builds.

kleyow
kleyow reviewed Oct 19, 2021
View reviewed changes
package.json Outdated Show resolved Hide resolved
@sivachundur sivachundur dismissed stale reviews from elnyry-sam-k and kleyow via beb9a01 October 19, 2021 15:09
@elnyry-sam-k elnyry-sam-k changed the title Adding currencies XXX & XTS which are part of ISO 4217 fix: adding currencies xxx and xts which are part of iso 4217 Oct 19, 2021
@kleyow
Copy link
Contributor

kleyow commented Oct 19, 2021

Leave the dependency upgrades for another PR.
There are some stuff in our tests that would need to be touched if you bump jest.

@sivachundur sivachundur merged commit f09fd82 into master Oct 19, 2021
@sivachundur sivachundur mentioned this pull request Oct 19, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elnyry-sam-k elnyry-sam-k elnyry-sam-k approved these changes

@mdebarros mdebarros Awaiting requested review from mdebarros

@eoln eoln Awaiting requested review from eoln

@lewisdaly lewisdaly Awaiting requested review from lewisdaly

@sridharvoruganti sridharvoruganti Awaiting requested review from sridharvoruganti

@vijayg10 vijayg10 Awaiting requested review from vijayg10

@kleyow kleyow Awaiting requested review from kleyow

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sivachundur @kleyow @elnyry-sam-k