fix(mojaloop/#2534): fspiop api version negotiation not handled by account lookup service #430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ansfers service
- chore: updated dependencies
- updated dependencies
- fixes for audit-resolve
- added eslint* to ncurc file due to compatibility-issues with standard
- added get-port to ncurc file due to breaking-changes/compatibility-issues with Node ES version support
- fix(mojaloop/#2536): fspiop api version negotiation not handled by transfers service - mojaloop/project#2536
- added getOptionsForFSPIOPHeaderValidation to the plugin configuration
- added new config key for PROTOCOL_VERSIONS to default and integration configs
- added DEFAULT_PROTOCOL_VERSION for backward compatibility
mdebarros
requested review from
elnyry-sam-k,
lewisdaly,
oderayi,
shashi165 and
vgenev
as code owners
elnyry-sam-k
previously approved these changes
Oct 20, 2021
mdebarros
changed the title
…DATELIST - ALS_PROTOCOL_VERSIONS__ACCEPT__VALIDATELIST can be set as follows "[ \"1\", \"1.1\"]" and it will be parsed correctly into a object - Note that MLAPI_PROTOCOL_VERSIONS__ACCEPT__DEFAULT is not currently used by the Account-lookup-service, I have not included this in the default.json, but it can be set (when implemented in future). I have also added a comment in the config.js to reflect this. - updated dependencies & fixed audit-resolve issues BREAKING CHANGE: Forcing a major version change for awareness of the config changes. The `LIB_RESOURCE_VERSIONS` env var is now deprecated, and this is now also controlled by the PROTOCOL_VERSIONS config in the default.json. This has been done for consistency between all API services going forward and unifies the config for both inbound and outbound Protocol API validation/transformation features.
lewisdaly
reviewed
Nov 3, 2021
I think that should be addressed in future: create a new story to replace RC with something more modern (i.e. Convict) which would be best suited for this purpose, and ensure that the replacement library will allow us to define a schema so that we can validate the config against for validation purposes. I think it would be a wiser and better time spent, as there is currently NO validation for any configurations on most of Mojaloop's service. Let me know your thoughts. |
elnyry-sam-k
approved these changes
Nov 5, 2021
|
looks good.. @lewisdaly any further comments? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chore: updated dependencies
fix(mojaloop/#2534): fspiop api version negotiation not handled by account lookup service - FSPIOP API version negotiation not handled - Account-lookup-service project#2534
BREAKING CHANGE: Forcing a major version change for awareness of the config changes. The
LIB_RESOURCE_VERSIONSenv var is now deprecated, and this is now also controlled by the PROTOCOL_VERSIONS config in the default.json. This has been done for consistency between all API services going forward and unifies the config for both inbound and outbound Protocol API validation/transformation features.