Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: sync pisp/master with v11.1.2 #382

Merged
merged 17 commits into from
Dec 23, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 16 additions & 13 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,14 +27,14 @@ defaults_Dependencies: &defaults_Dependencies |
npm install -g node-gyp

defaults_awsCliDependencies: &defaults_awsCliDependencies |
apk upgrade --no-cache
apk --no-cache add \
python3 \
py3-pip \
groff \
less \
mailcap
pip3 install --upgrade pip awscli==1.14.5 s3cmd==2.0.1 python-magic
apk upgrade --no-cache
apk --no-cache add \
python3 \
py3-pip \
groff \
less \
mailcap
pip3 install --upgrade pip awscli==1.14.5 s3cmd==2.0.1 python-magic
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest checking thatcheckout steps are after installing dependencies so checkout is done with the latest git


defaults_license_scanner: &defaults_license_scanner
name: Install and set up license-scanner
Expand Down Expand Up @@ -66,10 +66,10 @@ jobs:
setup:
executor: default-docker
steps:
- checkout
- run:
name: Install general dependencies
command: *defaults_Dependencies
- checkout
- run:
name: Access npm folder as root
command: cd $(npm root -g)/npm
Expand All @@ -87,10 +87,10 @@ jobs:
test-unit:
executor: default-docker
steps:
- checkout
- run:
name: Install general dependencies
command: *defaults_Dependencies
- checkout
- restore_cache:
keys:
- dependency-cache-{{ checksum "package.json" }}
Expand All @@ -109,13 +109,13 @@ jobs:
test-coverage:
executor: default-docker
steps:
- checkout
- run:
name: Install general dependencies
command: *defaults_Dependencies
- run:
name: Install AWS CLI dependencies
command: *defaults_awsCliDependencies
- checkout
- restore_cache:
keys:
- dependency-cache-{{ checksum "package.json" }}
Expand Down Expand Up @@ -236,14 +236,17 @@ jobs:
executor: anchore/anchore_engine
steps:
- setup_remote_docker
- checkout
- run:
name: Install docker dependencies for anchore
command: |
apk add --update python3 py3-pip docker python3-dev libffi-dev openssl-dev gcc libc-dev make jq npm
apk add --update py-pip docker python-dev libffi-dev openssl-dev gcc libc-dev make jq npm
- run:
name: Install general dependencies
command: *defaults_Dependencies
- run:
name: Install AWS CLI dependencies
command: *defaults_awsCliDependencies
- checkout
- attach_workspace:
at: /tmp
- run:
Expand Down
1 change: 1 addition & 0 deletions .env.example
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
LIB_RESOURCE_VERSIONS="transfers=1.1,participants=1.1"
10 changes: 1 addition & 9 deletions .ncurc.json
Original file line number Diff line number Diff line change
@@ -1,9 +1 @@
{
"reject": [
"@hapi/hapi",
"@hapi/inert",
"@hapi/vision",
"hapi-swagger",
"hapi-openapi"
]
}
{}
Loading