Feature/#1243 #1245 incorrect http and status code #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ervice into feature/#656ImplTesting # Conflicts: # package.json # test/unit/handlers/oracles.test.js
removed validator file as it isn't used may be required in MSISDN oracle as it validated mobile number formats
Fixes for sonarQube code sanity i.e removing function names that aren't needed, changing let to const, reordering functions in file Changed unique constraint on oracleEndpoint which is now working correctly
return undefined for currency when it is not available
# Conflicts: # package-lock.json # package.json
# Conflicts:
# src/handlers/parties/{Type}/{ID}/error.js
# Conflicts: # package-lock.json # package.json
…nto feature/#1243-#1245-incorrect-http-and-status-code-
…nto feature/#1243-#1245-incorrect-http-and-status-code-
fixed bug issues in story# mojaloop/project#1249
…nto feature/#1243-#1245-incorrect-http-and-status-code-
vgenev
approved these changes
Mar 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated central-services-shared