Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add WAF steps to user documentation #389

Merged
merged 3 commits into from
Nov 22, 2023
Merged

Conversation

BrianEllwood
Copy link
Contributor

Amend user documentation to add steps for implementing WAF to an application, for work carried out in issue #1929

@BrianEllwood BrianEllwood requested review from a team as code owners November 22, 2023 11:05
Copy link
Contributor

@julialawrence julialawrence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a link to a workflow that has these values set.

Copy link
Contributor

@julialawrence julialawrence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a suggestion around language.

source/documentation/apps/rshiny-app.md Outdated Show resolved Hide resolved
Co-authored-by: julialawrence <98329494+julialawrence@users.noreply.github.com>
@julialawrence julialawrence self-requested a review November 22, 2023 11:44
@BrianEllwood BrianEllwood merged commit 85b8927 into main Nov 22, 2023
2 checks passed
@BrianEllwood BrianEllwood deleted the add_waf_documentation branch November 22, 2023 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants