Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try catch for JSON parse - GrpcToHttpInterceptor #14

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Try catch for JSON parse - GrpcToHttpInterceptor #14

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
93a3fe0
fix: add try catch for JSON parse
mirkobertone Apr 9, 2024
3063b68
Version
mirkobertone Apr 9, 2024
09844a2
Version
mirkobertone Apr 9, 2024
067c940
Merge pull request #1 from mirkobertone/changeset-release/main
mirkobertone Apr 9, 2024
d16b867
Merge branch 'mohsenbostan:main' into main
mirkobertone Apr 11, 2024
ddb5427
Revert "Version"
mirkobertone Apr 11, 2024
ec472e4
Revert "Version"
mirkobertone Apr 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 24 additions & 8 deletions lib/interceptors/grpc-to-http.interceptor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,18 +29,34 @@ export class GrpcToHttpInterceptor implements NestInterceptor {
)
return throwError(() => err);

const exception = JSON.parse(err.details) as {
error: string | object;
type: string;
exceptionName: string;
};
const statusCode =
HTTP_CODE_FROM_GRPC[err.code] || HttpStatus.INTERNAL_SERVER_ERROR;

let exception: { exceptionName: any; error: any; type?: string };
try {
exception = JSON.parse(err.details) as {
error: string | object;
type: string;
exceptionName: string;
};
} catch (parseError) {
return throwError(
() =>
new HttpException(
{
message: err.details,
statusCode,
error: HttpStatus[statusCode],
},
statusCode,
{ cause: err },
),
);
}

if (exception.exceptionName !== RpcException.name)
return throwError(() => err);

const statusCode =
HTTP_CODE_FROM_GRPC[err.code] || HttpStatus.INTERNAL_SERVER_ERROR;

return throwError(
() =>
new HttpException(
Expand Down