Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Click defaults differ from kwarg defaults #126

Closed
moggers87 opened this issue Dec 7, 2019 · 0 comments · Fixed by #127
Closed

Click defaults differ from kwarg defaults #126

moggers87 opened this issue Dec 7, 2019 · 0 comments · Fixed by #127
Labels
bug
Milestone
3.2

Comments

@moggers87
Copy link
Owner

moggers87 commented Dec 7, 2019 •
edited
Loading

Getting this when starting Salmon 3.2.0rc1:

daemon.daemon.DaemonOSEnvironmentError: Unable to change file creation mask (an integer is required (got type NoneType))

This appears to be because click will pass in None if an option hasn't been used (unless we set a default in the decorator?)

Definitely need to check all other daemon commands and maybe check other commands too + add tests as required.
@moggers87 moggers87 added the bug label Dec 7, 2019
@moggers87 moggers87 added this to the 3.2 milestone Dec 7, 2019
moggers87 added a commit that referenced this issue Dec 10, 2019
@moggers87
start command now passes None rather than False
8cc0986 
`daemonize` function should now expect that

Also updated tests to make sure this mistake doesn't happen again

Fixes #126
@moggers87 moggers87 mentioned this issue Dec 10, 2019
Merged
moggers87 added a commit that referenced this issue Dec 10, 2019
@moggers87
start command now passes None rather than False
a651c4d 
`daemonize` function should now expect that

Also updated tests to make sure this mistake doesn't happen again

Fixes #126
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
3.2
Development

Successfully merging a pull request may close this issue.

start command now passes None rather than False moggers87/salmon
1 participant
@moggers87