Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Salmon commands don't return non-zero on error #112

Closed
moggers87 opened this issue Aug 8, 2019 · 0 comments · Fixed by #113
Closed

Salmon commands don't return non-zero on error #112

moggers87 opened this issue Aug 8, 2019 · 0 comments · Fixed by #113
Labels
bug

Comments

@moggers87
Copy link
Owner

For example:

$ salmon status; echo $?
Salmon not running.
0  # 0 is the exit for OK, but it's not OK!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Raise click exceptions to set correct exit codes in console commands moggers87/salmon
1 participant
@moggers87