Skip to content

Commit

Permalink
fix: Load full uncoalesced table if no partition columns available
Browse files Browse the repository at this point in the history
- When there are no partition columns, we should just load the whole table instead of hanging
- Tested with the snippet in the ticket
- Fixes deephaven#1763
  • Loading branch information
mofojed committed Feb 1, 2024
1 parent 1f47a8d commit 79e8543
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion packages/iris-grid/src/IrisGridTableModel.ts
Original file line number Diff line number Diff line change
Expand Up @@ -285,7 +285,11 @@ class IrisGridTableModel
}

get isPartitionRequired(): boolean {
return this.table.isUncoalesced && this.isValuesTableAvailable;
return (
this.table.isUncoalesced &&
this.isValuesTableAvailable &&
this.partitionColumns.length > 0
);
}

isFilterable(columnIndex: ModelIndex): boolean {
Expand Down

0 comments on commit 79e8543

Please sign in to comment.