PHP 8.4 compatibility updates #16646
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Once merged we'll also need to update the docs as those still mention older server requirements. |
Mark-H
approved these changes
Dec 11, 2024
I don't think this is going to get merged, honestly. I'd like to consider 2.x closed to feature requests and in order to actually support 8.4, we would need to update to a newer version of Smarty. This would cause BC breaks, and I don't want to go down that road. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Removes usage of deprecated features, updates minimum PHP support to >= 7.4, and updates PHPUnit to version 8.5.
Why is it needed?
Resolves various deprecation warnings for PHP 8.4 compatibility.
How to test
Test everything (including unit tests) in PHP 8.4
Related issue(s)/PR(s)
n/a