Big trash refactor #16600
Merged
Big trash refactor #16600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 3.x #16600 +/- ##
============================================
- Coverage 21.57% 21.55% -0.03%
- Complexity 10599 10600 +1
============================================
Files 561 561
Lines 32095 32107 +12
============================================
- Hits 6926 6922 -4
- Misses 25169 25185 +16 ☔ View full report in Codecov by Sentry. |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
theboxer
requested changes
Aug 29, 2024
|
@GulomovCreative do you think you’ll have time to get the update script for adding the new menu during an upgrade done? |
@rthrash Can I see some examples? I don't know how it works |
|
@GulomovCreative here are current upgrade scripts https://github.com/modxcms/revolution/blob/3.x/setup/includes/upgrades/mysql/3.1.0-pl.php you can check those or older ones for samples |
|
Added the upgrade script & adjusted the lexicon for context menu in the tree |
theboxer
approved these changes
Sep 5, 2024
Ibochkarev
approved these changes
Sep 6, 2024
theboxer
force-pushed
the
trash-refactor
branch
from
6291907 to
b439be0
Compare
|
@opengeek rebased to 3.x |
opengeek
force-pushed
the
trash-refactor
branch
from
b439be0 to
1820b1c
Compare
jenswittmann
pushed a commit
to jenswittmann/revolution
that referenced
this pull request
Dec 23, 2024
### What does it do? 1. Adds new "Trash" menu item to the top menu 2. Fixes modxcms#14190 3. Fixes trash button icon color change when its inactive 4. Removes unnecessary styles 5. Adds a purge button to the edit resource page 6. The resource tree and trash button state are now updates when a resource is deleted/undeleted on the resource update page 7. Fixes trash button tooltip information when purging resources on the trash page 8. Now when a resource have been delete/undelete in the resource tree, the state of the resource update form (checkbox and buttons) updates 9. Fixes undefined text of the trash button tooltip 10. Adds purge resource menu item to the context menu in the resource tree ### Why is it needed? There are many errors when deleting/restoring/purging resources ### How to test 1. — 2. Click by the middle mouse button on the trash button on the toolbar 3. Hover over the trash button when its inactive, before the icon changed color, now when inactive it does not 4. — 5. Open the edit resource page, delete it and you will see a new purging button 6. If you delete or restore a resource on the edit page, the resource tree and the trash button in the toolbar remain unchanged. Now the resource tree and the trash button will change their state 7. On the trash page when purging resources, the state of the trash button in the toolbar was not updated, now it will be 8. Create a resource, open its edit page and delete the resource **in the resource tree**, the state of the checkbox and buttons in the edit form will not change. Now everything works as it should. 9. If you delete a resource and when you hover the trash button, it will be undefined in the tooltip. Now the information will be correct 10. Open the context menu of resource tree, delete the resource and open again ### Related issue(s)/PR(s) modxcms#14190 --------- Co-authored-by: Jan Peca <pecajan@gmail.com> Co-authored-by: Jason Coward <jason@opengeek.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Why is it needed?
There are many errors when deleting/restoring/purging resources
How to test
Related issue(s)/PR(s)
#14190