Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify message when changing user passwords #16502

Merged
merged 2 commits into from
Feb 16, 2024
Merged

Clarify message when changing user passwords #16502

merged 2 commits into from
Feb 16, 2024

Conversation

Ruslan-Aleev
Copy link
Collaborator

Why is it needed?

When you change passwords for several users, it is not always clear which user's password was changed. The user's login and password are not visible.

user_before

user_after

Related issue(s)/PR(s)

N\A

@Ruslan-Aleev Ruslan-Aleev added type-frontend Issues related to UI/UX issues, mostly about styles and frontend implementations on JavaScript. feature Request about implementing a brand new function or possibility. area-lexicons Issues related to translations and lexicons implementation. pr/review-needed Pull request requires review and testing. labels Dec 13, 2023
@Ruslan-Aleev Ruslan-Aleev added this to the v3.0.5 milestone Dec 13, 2023
@codecov Codecov
Copy link

codecov bot commented Dec 13, 2023 •
edited
Loading

Codecov Report

Attention: 32 lines in your changes are missing coverage. Please review.

Comparison is base (73bfd27) 21.68% compared to head (e705e42) 21.68%.
Report is 102 commits behind head on 3.x.

❗ Current head e705e42 differs from pull request most recent head d58fe05. Consider uploading reports for the commit d58fe05 to get more accurate results

Files Patch % Lines
...src/Revolution/Processors/Security/User/Update.php 0.00% 20 Missing ⚠️
...src/Revolution/Processors/Security/User/Create.php 0.00% 12 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##                3.x   #16502      +/-   ##
============================================
- Coverage     21.68%   21.68%   -0.01%     
- Complexity    10496    10497       +1     
============================================
  Files           561      561              
  Lines         31703    31709       +6     
============================================
  Hits           6875     6875              
- Misses        24828    24834       +6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Ruslan-Aleev Ruslan-Aleev force-pushed the 3.x-user-pass-messages branch from e705e42 to d58fe05 Compare February 12, 2024 10:00
@Ruslan-Aleev
Copy link
Collaborator Author

@Mark-H Corrected, check.

@Mark-H
Copy link
Collaborator

Mark-H commented Feb 13, 2024

Thanks @Ruslan-Aleev.

(CI failing is not related to your PR.)

@Ibochkarev Ibochkarev added pr/ready-for-merging Pull request reviewed and tested and ready for merging. and removed pr/review-needed Pull request requires review and testing. labels Feb 14, 2024
@opengeek opengeek changed the title Change pop-up message about changing passwords for a user Clarify message when changing user passwords Feb 16, 2024
@opengeek opengeek merged commit f197da7 into modxcms:3.x Feb 16, 2024
1 of 5 checks passed
opengeek pushed a commit that referenced this pull request Feb 16, 2024
@Ruslan-Aleev @opengeek
Clarify message when changing user passwords (#16502)
3bbd1ba 
### Why is it needed?
When you change passwords for several users, it is not always clear
which user's password was changed. The user's login and password are not
visible.


![user_before](https://github.com/modxcms/revolution/assets/12523676/da976af8-d489-4a40-8bcb-1acece6c084d)


![user_after](https://github.com/modxcms/revolution/assets/12523676/d38a55d8-ea21-4682-94f0-49bedb6f0cac)

### Related issue(s)/PR(s)
N\A
@Ruslan-Aleev Ruslan-Aleev deleted the 3.x-user-pass-messages branch February 19, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ibochkarev Ibochkarev Ibochkarev approved these changes

@Mark-H Mark-H Mark-H approved these changes

@opengeek opengeek Awaiting requested review from opengeek opengeek is a code owner

Assignees
No one assigned
Labels
area-lexicons Issues related to translations and lexicons implementation. feature Request about implementing a brand new function or possibility. pr/ready-for-merging Pull request reviewed and tested and ready for merging. type-frontend Issues related to UI/UX issues, mostly about styles and frontend implementations on JavaScript.
Projects
None yet
Milestone
v3.0.5
Development

Successfully merging this pull request may close these issues.
4 participants
@Ruslan-Aleev @Mark-H @Ibochkarev @opengeek