Add .nvmrc #16478
Merged
Add .nvmrc #16478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theboxer
approved these changes
Sep 29, 2023
Mark-H
approved these changes
Sep 29, 2023
Ibochkarev
added
the
pr/ready-for-merging
opengeek
pushed a commit
that referenced
this pull request
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Adds a simple .nvmrc file to the templates directory to help target the same build version of node specified in the GitHub workflow.
Why is it needed?
Using a non-matching version of node can have unintended consequences when building.
How to test
With nvm installed you should now be able to run
nvm usein the templates directory before node install and apply the correct version of node that is intended.