Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix subsubnav position issue #15970

Merged
merged 2 commits into from
Jan 17, 2022
Merged

Fix subsubnav position issue #15970

merged 2 commits into from
Jan 17, 2022

Conversation

Jako
Copy link
Collaborator

@Jako Jako commented Jan 14, 2022

What does it do?

Add a parent based class modx-subnav-<parent> to the modx-subnav. Change the css to change the position.

Why is it needed?

Fix the position of the subsubnav on base of the subnav position.

How to test

See #15969 (Create a submenu in the extras menu and add some submenus inside)

Related issue(s)/PR(s)

#15969

@Jako Jako requested review from Mark-H and opengeek as code owners January 14, 2022 13:08
@cla-bot cla-bot bot added the cla-signed CLA confirmed for contributors to this PR. label Jan 14, 2022
@Jako Jako added the bug The issue in the code or project, which should be addressed. label Jan 14, 2022
@Jako Jako added this to the v3.0.0-rc1 milestone Jan 14, 2022
@Ibochkarev Ibochkarev added the pr/ready-for-merging Pull request reviewed and tested and ready for merging. label Jan 14, 2022
@opengeek opengeek merged commit 9b0a93d into modxcms:3.x Jan 17, 2022
@Jako Jako deleted the subsubnav-position branch January 17, 2022 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug The issue in the code or project, which should be addressed. cla-signed CLA confirmed for contributors to this PR. pr/ready-for-merging Pull request reviewed and tested and ready for merging.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants