Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert lexicon entries in all namespaces #14442

Open
JonikUl opened this issue Mar 1, 2019 · 3 comments
Open

Revert lexicon entries in all namespaces #14442

JonikUl opened this issue Mar 1, 2019 · 3 comments
Labels
area-lexicons Issues related to translations and lexicons implementation. feature Request about implementing a brand new function or possibility.
Milestone

Comments

@JonikUl
Copy link

JonikUl commented Mar 1, 2019

Feature request

Summary

At the moment only the core lexicon entries could be reset with the button 'Revert All Core Entries' in the lexicon management. It would be nice to reset other lexicon namespaces too.

Current behaviour

  • Change a value in a lexicon not in the core namespace.
  • Use Revert All Core Entries button.
  • The same value remains.

Improved behavior

Environment

MODX 2.7.1

lex

@JoshuaLuckers JoshuaLuckers added area-lexicons Issues related to translations and lexicons implementation. bug The issue in the code or project, which should be addressed. labels Mar 1, 2019
@Jako
Copy link
Collaborator

Jako commented Mar 1, 2019

The button works well for the core lexicon workspace on my local 2.7.1 installation. But not in other (selected) namespaces.

This is not a bug because of the text of the button. But the behaviour could be changed by sending the selected namespace to the processor and change the button text.

@Jako Jako added feature Request about implementing a brand new function or possibility. and removed bug The issue in the code or project, which should be addressed. labels Mar 1, 2019
@Jako Jako changed the title Revert All Core Entries in Lexicons Revert lexicon entries in all namespaces Mar 1, 2019
@Jako
Copy link
Collaborator

Jako commented Mar 1, 2019

I have changed the issue into a feature request. Is this ok?

@Ruslan-Aleev
Copy link
Collaborator

Ruslan-Aleev commented Mar 1, 2019

Very strange button :) The button work only for "core", although the first one in the list of namespaces may be not "core", but, for example, "ace".
Today we noticed this bug, the problem is also in translation, for example, in Russian, there is no mention that the button only works for "core". We tested in Russian, and when we recorded gif we didn’t pay attention to the original name in English.

@Jako Jako added this to the v3.0.0-alpha milestone Mar 3, 2019
@opengeek opengeek modified the milestones: v3.0.0-alpha2, v3.0.0-alpha3 Jan 29, 2020
@opengeek opengeek modified the milestones: v3.0.0-beta1, v3.0.0-beta2 Nov 9, 2021
@opengeek opengeek modified the milestones: v3.0.0-beta2, v3.0.0-rc1 Nov 23, 2021
@opengeek opengeek modified the milestones: v3.0.0-rc1, v3.0.0-rc2, v3.1.0 Jan 20, 2022
opengeek added a commit that referenced this issue Mar 25, 2024
### What does it do?
Add reloading of lexicon entries for any namespace:

- Move the button up, it's was almost invisible.
- Added a pop-up window with confirmation, where the namespace, topic
and language are indicated.
- The name of the strings is now returned to the console, and not just
their amount.


![lexicons_reload](https://user-images.githubusercontent.com/12523676/208910173-49426e6e-a70a-4c55-9ced-4e1a0afdcb5a.gif)

p.s. In a good way, this PR should be improved and merged after this
(#15942), although the current
version is also working.

### Related issue(s)/PR(s)
#16333
#14442

---------

Co-authored-by: Jason Coward <jason@opengeek.com>
@opengeek opengeek modified the milestones: v3.1.0, v3.1.1 Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-lexicons Issues related to translations and lexicons implementation. feature Request about implementing a brand new function or possibility.
Projects
None yet
Development

No branches or pull requests

6 participants