Skip to content

Commit

Permalink
Add guard-clause to clearDirty method (#16467)
Browse files Browse the repository at this point in the history
### What does it do?
This makes sure the JS doesn't throw an error in the case that the
items-object is an array, just like in
#16404 for 3.x

### Why is it needed?
When using ExtJS to create components of the xtype: 'radiogroup' to be
used in CMPs inside a form,
this function gets called and tries to iterate over it's items array
with a method that doesn't exist.

This PR isn't changing the way forms or the clearDirty-method are
handled, it just assures no error is thrown when using
radiogroup-components.

### Related issue(s)/PR(s)
Resolves modmore/ClientConfig#202
Resolves modmore/ClientConfig#176
Resolves modmore/ClientConfig#143

---------

Co-authored-by: Jason Coward <jason@opengeek.com>
  • Loading branch information
sebastian-marinescu and opengeek authored Mar 22, 2024
1 parent f7974d1 commit 3446d08
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
Loading

0 comments on commit 3446d08

Please sign in to comment.