Skip to content

Commit

Permalink
fix: solve issue during refresh (#160)
Browse files Browse the repository at this point in the history
  • Loading branch information
zhangHongEn authored Oct 12, 2024
1 parent e5f0faa commit fddfdd8
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 3 deletions.
4 changes: 2 additions & 2 deletions src/utils/normalizeModuleFederationOptions.ts
Original file line number Diff line number Diff line change
Expand Up @@ -267,7 +267,7 @@ export interface NormalizedModuleFederationOptions {
manifest: ManifestOptions | boolean;
dev?: boolean | PluginDevOptions;
dts?: boolean | PluginDtsOptions;
shareStrategy?: ShareStrategy;
shareStrategy: ShareStrategy;
getPublicPath?: string;
}

Expand Down Expand Up @@ -343,6 +343,6 @@ export function normalizeModuleFederationOptions(
dev: options.dev,
dts: options.dts,
getPublicPath: options.getPublicPath,
shareStrategy: options.shareStrategy,
shareStrategy: options.shareStrategy || 'version-first',
});
}
7 changes: 6 additions & 1 deletion src/virtualModules/virtualRemoteEntry.ts
Original file line number Diff line number Diff line change
Expand Up @@ -126,9 +126,14 @@ export function generateRemoteEntry(options: NormalizedModuleFederationOptions):
remotes: usedRemotes,
shared: usedShared,
plugins: [${pluginImportNames.map((item) => `${item[0]}()`).join(', ')}],
${options.shareStrategy ? `shareStrategy: ${options.shareStrategy}` : ''}
${options.shareStrategy ? `shareStrategy: '${options.shareStrategy}'` : ''}
});
initRes.initShareScopeMap('${options.shareScope}', shared);
try {
await Promise.all(await initRes.initializeSharing('${options.shareScope}', {strategy: '${options.shareStrategy}'}));
} catch (e) {
console.error(e)
}
initResolve(initRes)
return initRes
}
Expand Down

0 comments on commit fddfdd8

Please sign in to comment.