feat(dts-plugin): add IPV6 property to DTS Plugin #3421
Conversation
🦋 Changeset detectedLatest commit: 05c700a The changes in this PR will be included in the next version bump. This PR includes changesets to release 29 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for module-federation-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@2heal1 - I know you are assigned this issue, but how do you feel about this new setting? |
|
i see both node.js and axios use |
I think we can safely just omit the { family } object when its ipv6, but explicitly setting it should be fine. Right now it will just set family to 4 or 6 based on the new DTS config param. The http agent is passed to axios, so axios will respect what the underlying agent is configured to. Is there another location to look for nodejs? |
|
Emm i want to follow the standard named options because if new ipversion coming the |
Updated :) |
| @@ -144,6 +144,7 @@ export interface DtsHostOptions { | |||
| maxRetries?: number; | |||
| consumeAPITypes?: boolean; | |||
| runtimePkgs?: string[]; | |||
| ipVersion?: 'ipv4' | 'ipv6'; | |||
There was a problem hiding this comment.
can you set the field as family , so no need to add transform helper
There was a problem hiding this comment.
I can, the name "family" felt a little ambiguous at first and the types are a bit weird since multiple layers of the config can be a boolean or the type so there is a lot of casting involved - which the helper/util method sort of abstracted away
There was a problem hiding this comment.
@2heal1 - updated, let me know if you want me to just inline the type handling and remove the util method
There was a problem hiding this comment.
That's fine . Thanks for contributing! Approved~
There was a problem hiding this comment.
Thanks! Let me test this a bit further
There was a problem hiding this comment.
Yeah sure , when you ready to merge just pin me
|
Hi ,do you ready to merge ? |
I've been testing this a little bit and it seems it still requires setting the rspack dev server to a host value of 127.0.0.1, at least in my case. I'm thinking it's more on the host side than the requesting side or possibly both. Need to test more |
Added IPv6 property to the DTS plugin
#3382