-
-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fix call undefined delegate #1149
Changes from 5 commits
b39e62b
8a0f95f
d657030
3204964
e78f00c
8816c61
b30c0fc
663e202
0928119
0543e97
996ebb8
db5c156
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -457,7 +457,9 @@ class FederationStatsPlugin { | |
// Iterate over each dependency within the block. | ||
for (const dep of blockmodule.dependencies) { | ||
// Get the module that corresponds to the dependency. | ||
const { module } = compilation.moduleGraph.getConnection(dep); | ||
const connection = compilation.moduleGraph.getConnection(dep); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. only search valid module connections to relocate in graph |
||
if(!connection) continue; | ||
const { module } = connection; | ||
const moduleChunks = | ||
compilation.chunkGraph.getModuleChunksIterable(module); | ||
// Iterate over each chunk associated with the module. | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,7 +2,7 @@ | |
|
||
import type { Compiler, container } from 'webpack'; | ||
import type { ModuleFederationPluginOptions } from '../types'; | ||
import { extractUrlAndGlobal } from '@module-federation/utilities'; | ||
import { extractUrlAndGlobal } from '@module-federation/utilities/src/utils/pure'; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. move pure utils to pure folder for smaller footprint of code moved into runtime module as eager |
||
|
||
interface NodeFederationOptions extends ModuleFederationPluginOptions { | ||
experiments?: Record<string, unknown>; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
testing eager import which should break application