Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/building electron with todesktop #418

Merged
merged 76 commits into from
Mar 28, 2024

Conversation

Fredkiss3
Copy link
Contributor

@Fredkiss3 Fredkiss3 commented Mar 15, 2024

A proper implementation of #342 , refer to it to know which strategy we used to build the nextjs app and include it in the electron bundle.

This PR add a proper setup for building and publishing the electron app, the process is like this :

  • When we merge to the production branch, it will build and deploy a production build on vercel, and if that is succesfull, trigger the CI for the electron build & release workflow.
  • I also make sure to add an optional workflow that can be run on each PR that builds and test the electron app, this to make sure that changes we made didn't break the electron app.

Copy link

vercel bot commented Mar 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
canary ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 28, 2024 2:58am
explorer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 28, 2024 2:58am
6 Ignored Deployments
Name Status Preview Comments Updated (UTC)
aeg ⬜️ Ignored (Inspect) Visit Preview Mar 28, 2024 2:58am
apricot ⬜️ Ignored (Inspect) Visit Preview Mar 28, 2024 2:58am
proteus ⬜️ Ignored (Inspect) Visit Preview Mar 28, 2024 2:58am
saga ⬜️ Ignored (Inspect) Visit Preview Mar 28, 2024 2:58am
waev ⬜️ Ignored (Inspect) Visit Preview Mar 28, 2024 2:58am
worlds ⬜️ Ignored (Inspect) Visit Preview Mar 28, 2024 2:58am

@lzrscg lzrscg merged commit 9b0a842 into canary Mar 28, 2024
11 checks passed
@lzrscg lzrscg deleted the fredkiss3/building-electron-with-todesktop branch March 28, 2024 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants