[stdlib] Hristo/foundations for os process module #4017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add `read_bytes` capability to `FileDecscriptor` - Add file descriptor controls function to Libc. bindings - Adds vfork, execvp, kill system call utils. to Mojos cLib binds Signed-off-by: Hristo I. Gueorguiev <53634432+izo0x90@users.noreply.github.com>
Update `read_bytes` from Span[Byte] to List[Byte] for better memory safety and "user ergonomics" Signed-off-by: Hristo I. Gueorguiev <53634432+izo0x90@users.noreply.github.com>
izo0x90
changed the title
|
@ConnorGray @JoeLoser @owenhilyard Foundational changes broken off into their own branch/ PR. 😃 |
Update the list creation to conform to upcoming List API changes that make the list size a `private attribute` Signed-off-by: Hristo I. Gueorguiev <53634432+izo0x90@users.noreply.github.com>
Awesome 😃, all set. |
ConnorGray
reviewed
Feb 25, 2025
ConnorGray
reviewed
Feb 25, 2025
owenhilyard
reviewed
Feb 25, 2025
JoeLoser
reviewed
Feb 25, 2025
ConnorGray
reviewed
Feb 25, 2025
There was a problem hiding this comment.
Hi @izo0x90, thanks for splitting this off, this is great! 🙂
I've left a few minor comments, mostly suggestions that we include links to the POSIX docs where appropriate. Once those are addressed, I'll proceed with merging this in.
In the meantime, I'll !sync this preemptively, just to ensure it passes internal CI.
Thanks again for contributing to Mojo 🔥
|
!sync |
modularbot
added
the
imported-internally
Co-authored-by: Connor Gray <accounts@connorgray.com> Signed-off-by: Hristo (Izo) G. <53634432+izo0x90@users.noreply.github.com>
Co-authored-by: Connor Gray <accounts@connorgray.com> Signed-off-by: Hristo (Izo) G. <53634432+izo0x90@users.noreply.github.com>
Co-authored-by: Connor Gray <accounts@connorgray.com> Signed-off-by: Hristo (Izo) G. <53634432+izo0x90@users.noreply.github.com>
Co-authored-by: Connor Gray <accounts@connorgray.com> Signed-off-by: Hristo (Izo) G. <53634432+izo0x90@users.noreply.github.com>
Co-authored-by: Connor Gray <accounts@connorgray.com> Signed-off-by: Hristo (Izo) G. <53634432+izo0x90@users.noreply.github.com>
Co-authored-by: Connor Gray <accounts@connorgray.com> Signed-off-by: Hristo (Izo) G. <53634432+izo0x90@users.noreply.github.com>
Co-authored-by: Connor Gray <accounts@connorgray.com> Signed-off-by: Hristo (Izo) G. <53634432+izo0x90@users.noreply.github.com>
- `read_bytes` takes in Span[Byte] buffer as opposed to allocating to avoid n+1 alloc. issues etc. - Remove c_str_ptr type from ffi module since it is not a convention set by C lang., it will potentially get added back in at a later date after discussions and under its own PR - Doc string updates to libC funcs. Co-authored-by: Connor Gray <accounts@connorgray.com> Signed-off-by: Hristo (Izo) G. <53634432+izo0x90@users.noreply.github.com>
izo0x90
requested review from
ConnorGray,
owenhilyard,
martinvuyk and
JoeLoser
Co-authored-by: martinvuyk <110240700+martinvuyk@users.noreply.github.com> Signed-off-by: Hristo (Izo) G. <53634432+izo0x90@users.noreply.github.com>
Co-authored-by: martinvuyk <110240700+martinvuyk@users.noreply.github.com> Signed-off-by: Hristo (Izo) G. <53634432+izo0x90@users.noreply.github.com>
Co-authored-by: martinvuyk <110240700+martinvuyk@users.noreply.github.com> Signed-off-by: Hristo (Izo) G. <53634432+izo0x90@users.noreply.github.com>
izo0x90
force-pushed
the
Hristo/Foundations-for-os-process-module
branch
from
8dd69a0 to
f2800a9
Compare
|
Awesome, thanks for incorporating the feedback @izo0x90 🙂 I'll go ahead and sync this in. |
|
!sync |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sets up the foundation for implementing the
os/processmodule PR with process module changesread_bytescapability toFileDecscriptor