-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
logs id
command
#3196
logs id
command
#3196
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. Summarizing from my comments: I prefer if you rename the command from logs id -> logs key, and remove the open check from L1225 to L1232.
Have completed the requested changes. While if a log is open it will show this Can see here it is a commented known bug |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything else looks great, thanks for the changes.
* Update modmail.py * Update clients.py * Formatting * Change log id to log key, added id as an alias * Print the log even if it is closed and fix bug * Update modmail.py * Added a missing period * Updated changelog --------- Co-authored-by: Taku <45324516+Taaku18@users.noreply.github.com>
* Update modmail.py * Update clients.py * Formatting * Change log id to log key, added id as an alias * Print the log even if it is closed and fix bug * Update modmail.py * Added a missing period * Updated changelog --------- Co-authored-by: Taku <45324516+Taaku18@users.noreply.github.com> (cherry picked from commit b1f3645) Signed-off-by: Khakers <22665282+khakers@users.noreply.github.com>
* Update modmail.py * Update clients.py * Formatting * Change log id to log key, added id as an alias * Print the log even if it is closed and fix bug * Update modmail.py * Added a missing period * Updated changelog --------- Co-authored-by: Taku <45324516+Taaku18@users.noreply.github.com> (cherry picked from commit b1f3645) Signed-off-by: Khakers <22665282+khakers@users.noreply.github.com>
Added command
logs id <key>
, this helps users locate the log link / preview if they just have the log id.This will help once a Heroku alternative is found and users log link changes due to moving from Heroku. They can use this command to bring up the new link easily
Have tested this.
Remade the PR because I changed the branch