-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved status command #119
Conversation
Add new configuration variable for "Custom response message for thread creation"
Can you increment the bot version and add the changes into the changelog? |
Sure thing, I'm going to be working on the ?status command as well for watching, listening, etc. |
I just realized, we should increment the |
Currently going to test on own instance. Quickly just adding the code.
You may need to store |
Can push now. |
I don't think in its current state the status command will work. |
I'm not fond of the new discord rewrite, I completely broke the status command and haven't really debugged how to fix it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Status command does not work.
Refer below:
# Setting `Playing ` status
await bot.change_presence(activity=discord.Game(name="a game"))
# Setting `Streaming ` status
await bot.change_presence(activity=discord.Streaming(name="My Stream", url=my_twitch_url))
# Setting `Listening ` status
await bot.change_presence(activity=discord.Activity(type=discord.ActivityType.listening, name="a song"))
# Setting `Watching ` status
await bot.change_presence(activity=discord.Activity(type=discord.ActivityType.watching, name="a movie"))
ActivityType enum: https://github.com/Rapptz/discord.py/blob/rewrite/discord/enums.py#L216-L221
Activity class: https://github.com/Rapptz/discord.py/blob/rewrite/discord/activity.py#L80-L128
@@ -270,18 +270,20 @@ def format_not_found(self, ctx, command): | |||
|
|||
@commands.command(name='status', aliases=['customstatus', 'presence']) | |||
@commands.has_permissions(administrator=True) | |||
async def _status(self, ctx, *, message): | |||
async def _status(self, ctx, *, statusType, message): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use snake_case
I added the custom thread creation message in #124 |
Closing due to author not being able to finish the PR |
The configuration variable name is kind of weird, no clue if that should be changed. I don't know if I used self.bot.config.get() correct either but based on the code it takes in 2 parameters for the configuration variable to get, and if that configuration variable isn't set it picks a default or the 2nd parameter. This pull request closes #87 and closes #116