Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix code scanning alert - Incomplete URL substring sanitization #3291

Closed
2 tasks
Taaku18 opened this issue Jul 10, 2023 · 1 comment
Closed
2 tasks

Fix code scanning alert - Incomplete URL substring sanitization #3291

Taaku18 opened this issue Jul 10, 2023 · 1 comment
Assignees
@Taaku18
Labels
staged Staged for next version

Comments

@Taaku18
Copy link
Collaborator

Taaku18 commented Jul 10, 2023

Tracking issues for:

I don't see how these are vulnerabilities. But since CodeQL says so, I'll replace it with a better way.
@Taaku18 Taaku18 self-assigned this Jul 10, 2023
@RealCyGuy
Copy link
Member

I don't think it's a vulnerability, but it could cause unexpected behaviour if an image url was https://gyazo.com.example.com/image.png for example.

@Taaku18 Taaku18 added staged Staged for next version and removed in progress labels Nov 20, 2023
raidensakura pushed a commit to raidensakura/modmail that referenced this issue Apr 10, 2024
@Taaku18 @raidensakura
Fix modmail-dev#3291: Resolve code scanning alert for URL sanitization
044b85d
khakers pushed a commit to khakers/OpenModmail that referenced this issue Jun 18, 2024
@Taaku18 @khakers
Fix modmail-dev#3291: Resolve code scanning alert for URL sanitization
9d375df 
(cherry picked from commit 2b66710)
khakers pushed a commit to khakers/OpenModmail that referenced this issue Jun 18, 2024
@Taaku18 @khakers
Fix modmail-dev#3291: Resolve code scanning alert for URL sanitization
ea37687 
(cherry picked from commit 2b66710)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Taaku18 Taaku18

Labels
staged Staged for next version
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Taaku18 @RealCyGuy