fix(gridintersect): add multilinestring tests #1924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
docs(misc): clean up docstrings
for unsupported methods
ensure one entry per grid cell in polygon intersection result add test for this case
bug in structured mode where linestrings were not handled correctly if they pass in and out of grid cell
- fix vertices when intersecting linestring with offset grids
- tests for example in modflowpy#1922
|
Lots of merges in the list of commits so a squash and merge is probably a good idea? |
|
We will squash and merge this. In the future, you may try rebasing to avoid all these merge commits. There are a couple of ways to do this, as we describe here for the MODFLOW 6 repo. |
Codecov Report
@@ Coverage Diff @@
## develop #1924 +/- ##
=========================================
- Coverage 72.6% 72.5% -0.1%
=========================================
Files 257 257
Lines 57604 57604
=========================================
- Hits 41832 41814 -18
- Misses 15772 15790 +18 |
langevin-usgs
approved these changes
Aug 21, 2023
wpbonelli
pushed a commit
that referenced
this pull request
Aug 25, 2023
- tests for example in #1922
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add tests for problem in #1922