Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not process scripts with non-JS type attribute #1767

Merged
merged 2 commits into from
Nov 6, 2021

Conversation

smartrejames
Copy link
Contributor

What I did

  1. dev-server-esbuild: fix "importmap" or other non-js type in html file

@changeset-bot
Copy link

changeset-bot bot commented Nov 6, 2021

🦋 Changeset detected

Latest commit: 17617fe

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@web/dev-server-esbuild Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@web-padawan web-padawan changed the title fix compiling html with non-js types fix: do not process scripts with non-JS type attribute Nov 6, 2021
Copy link
Contributor

@web-padawan web-padawan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, the solution looks good to me 👍

@web-padawan web-padawan merged commit d406c77 into modernweb-dev:master Nov 6, 2021
@smartrejames smartrejames deleted the fix-html-importmap branch November 6, 2021 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants