fix: Add Bitbucket type checking for scm/ stripping
#84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmccarp
reviewed
Jul 15, 2024
| log.warn("No scm origin found for %s. Consider adding it to scm-origins.txt".formatted(cloneUrl)); | ||
| return; | ||
| } else { | ||
| throw new IllegalStateException("No scm origin found for %s. Add it to scm-origins.txt or set organizations.allow-missing-scm-origins to true".formatted(cloneUrl)); | ||
| throw new IllegalStateException("No scm origin found for %s. Add it to moderne.scm.repositories or set moderne.scm.allow-missing-scm-origins to true".formatted(cloneUrl)); |
There was a problem hiding this comment.
Should we add in application.yml to this message so they know where to set it?
kmccarp
approved these changes
Jul 15, 2024
pstreef
added a commit
that referenced
this pull request
Jul 18, 2024
* Remove '/scm' path prefix * Add test and fix implementation * formatting * formatting * Update src/main/resources/repos.csv Co-authored-by: Kevin Carpenter™️ <kevin@moderne.io> * Update src/test/java/io/moderne/organizations/OrganizationStructureServiceTest.java Co-authored-by: Kevin Carpenter™️ <kevin@moderne.io> * Update src/main/java/io/moderne/organizations/OrganizationStructureService.java Co-authored-by: Kevin Carpenter™️ <kevin@moderne.io> * fix: Add Bitbucket type checking for `scm/` stripping (#84) * Merge conflict * fix test --------- Co-authored-by: Kevin Carpenter™️ <kevin@moderne.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.