Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(QYOG-145): tab 예외처리로직, 변경로직 위치 변경 #79

Merged
merged 2 commits into from
May 2, 2024
Merged

fix(QYOG-145): tab 예외처리로직, 변경로직 위치 변경 #79

merged 2 commits into from
May 2, 2024

Conversation

pho9902
Copy link
Collaborator

@pho9902 pho9902 commented Apr 30, 2024 •
edited by jira bot
Loading

Pull Request

티켓

티켓명과 url은 수정해주세요.

QYOG-145

작업 내용

  • getServerSideProps 에 위치한 초기 tab 값 지정, 예외처리 로직을 컴포넌트 내에서 상태, useEffect 로 관리하는 방식으로 변경

기타

  • PR에 대한 추가 코멘트

@pho9902 pho9902 added the 🐞 Bug Fix 버그 수정 label Apr 30, 2024
@pho9902 pho9902 requested a review from jsj1510 April 30, 2024 06:54
@pho9902 pho9902 self-assigned this Apr 30, 2024
@vercel Vercel
Copy link

vercel bot commented Apr 30, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dongurami-front-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 30, 2024 7:23am

@soonki-98 soonki-98 merged commit 86c1bc1 into develop May 2, 2024
4 checks passed
@soonki-98 soonki-98 deleted the fix/woo/QYOG-145 branch May 2, 2024 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soonki-98 soonki-98 soonki-98 approved these changes

@jsj1510 jsj1510 jsj1510 approved these changes

Assignees

@pho9902 pho9902

Labels
🐞 Bug Fix 버그 수정
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pho9902 @soonki-98 @jsj1510