-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(QYOG-37): 로그인 모달 작업 #74
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
src/containers/Login/Form/emotion.ts
Outdated
export const Regist = styled.h3` | ||
color: ${({ theme }) => theme.color.primary_100}; | ||
font-family: "Noto Sans"; | ||
font-size: 48px; | ||
font-style: normal; | ||
font-weight: 700; | ||
line-height: normal; | ||
margin: 2% 0 4% 0; | ||
`; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typography 사용해서 대체해도 될듯
src/containers/Login/Form/emotion.ts
Outdated
justify-content: center; | ||
align-items: center; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
순기가 justify-content랑 align-items은 verticalAlign, horizonAlign 이걸로 사용하자고 하더라 맞춰쓰면 좋을듯
src/containers/Login/Form/emotion.ts
Outdated
width: 1265px; | ||
height: 802px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이렇게 쓰이는 px은 converter의 pxtorem으로 쓰는게 맞지않나?
Pull Request
티켓
티켓명과 url은 수정해주세요.
QYOG-37
작업 내용
스크린샷
기타