feat(QYOG-37): 로그인 모달 작업 #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jsj1510
reviewed
Mar 26, 2024
src/containers/Login/Form/emotion.ts
Outdated
Comment on lines
52
to
60
| export const Regist = styled.h3` | ||
| color: ${({ theme }) => theme.color.primary_100}; | ||
| font-family: "Noto Sans"; | ||
| font-size: 48px; | ||
| font-style: normal; | ||
| font-weight: 700; | ||
| line-height: normal; | ||
| margin: 2% 0 4% 0; | ||
| `; |
src/containers/Login/Form/emotion.ts
Outdated
Comment on lines
71
to
72
| justify-content: center; | ||
| align-items: center; |
There was a problem hiding this comment.
순기가 justify-content랑 align-items은 verticalAlign, horizonAlign 이걸로 사용하자고 하더라 맞춰쓰면 좋을듯
src/containers/Login/Form/emotion.ts
Outdated
Comment on lines
16
to
17
| width: 1265px; | ||
| height: 802px; |
There was a problem hiding this comment.
이렇게 쓰이는 px은 converter의 pxtorem으로 쓰는게 맞지않나?
jsj1510
approved these changes
Apr 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
티켓
티켓명과 url은 수정해주세요.
QYOG-37
작업 내용
스크린샷
기타